-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic on AMD Radeon laptop gpu with Windows 11 #3373
Comments
@DJMcNab looks simillar. |
Update to latest version of wgpu with git did not helped (after fixing compilation errors)
|
My changeset: Index: crates/bevy_ui/src/render/pipeline.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_ui/src/render/pipeline.rs b/crates/bevy_ui/src/render/pipeline.rs
--- a/crates/bevy_ui/src/render/pipeline.rs (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_ui/src/render/pipeline.rs (date 1639856841398)
@@ -4,6 +4,7 @@
};
use crevice::std140::AsStd140;
+use wgpu::{SamplerBindingType};
pub struct UiPipeline {
pub view_layout: BindGroupLayout,
@@ -44,10 +45,7 @@
BindGroupLayoutEntry {
binding: 1,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
],
@@ -114,8 +112,8 @@
primitive: PrimitiveState {
front_face: FrontFace::Ccw,
cull_mode: None,
+ unclipped_depth: false,
polygon_mode: PolygonMode::Fill,
- clamp_depth: false,
conservative: false,
topology: PrimitiveTopology::TriangleList,
strip_index_format: None,
Index: crates/bevy_ui/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_ui/Cargo.toml b/crates/bevy_ui/Cargo.toml
--- a/crates/bevy_ui/Cargo.toml (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_ui/Cargo.toml (date 1639856545831)
@@ -29,7 +29,8 @@
# other
stretch = "0.3.2"
-serde = {version = "1", features = ["derive"]}
+serde = { version = "1", features = ["derive"] }
smallvec = { version = "1.6", features = ["union", "const_generics"] }
bytemuck = { version = "1.5", features = ["derive"] }
-crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
\ No newline at end of file
+crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu" }
\ No newline at end of file
Index: crates/bevy_sprite/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_sprite/Cargo.toml b/crates/bevy_sprite/Cargo.toml
--- a/crates/bevy_sprite/Cargo.toml (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_sprite/Cargo.toml (date 1639856322021)
@@ -31,3 +31,4 @@
thiserror = "1.0"
rectangle-pack = "0.4"
serde = { version = "1", features = ["derive"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu" }
\ No newline at end of file
Index: crates/bevy_pbr/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/Cargo.toml b/crates/bevy_pbr/Cargo.toml
--- a/crates/bevy_pbr/Cargo.toml (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/Cargo.toml (date 1639855418822)
@@ -27,4 +27,4 @@
# direct dependency required for derive macro
bytemuck = { version = "1", features = ["derive"] }
crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
-wgpu = { version = "0.11.0", features = ["spirv"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", features = ["spirv"] }
Index: crates/bevy_gltf/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_gltf/Cargo.toml b/crates/bevy_gltf/Cargo.toml
--- a/crates/bevy_gltf/Cargo.toml (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_gltf/Cargo.toml (date 1639856399495)
@@ -29,4 +29,4 @@
anyhow = "1.0.4"
base64 = "0.13.0"
percent-encoding = "2.1"
-wgpu = "0.11.0"
+wgpu = { git = "https://github.com/gfx-rs/wgpu" }
Index: crates/bevy_pbr/src/render/light.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/src/render/light.rs b/crates/bevy_pbr/src/render/light.rs
--- a/crates/bevy_pbr/src/render/light.rs (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/src/render/light.rs (date 1639856841407)
@@ -293,8 +293,8 @@
strip_index_format: None,
front_face: FrontFace::Ccw,
cull_mode: None,
+ unclipped_depth: false,
polygon_mode: PolygonMode::Fill,
- clamp_depth: false,
conservative: false,
},
depth_stencil: Some(DepthStencilState {
Index: crates/bevy_sprite/src/render/mod.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_sprite/src/render/mod.rs b/crates/bevy_sprite/src/render/mod.rs
--- a/crates/bevy_sprite/src/render/mod.rs (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_sprite/src/render/mod.rs (date 1639856841383)
@@ -26,6 +26,7 @@
use bevy_utils::HashMap;
use bytemuck::{Pod, Zeroable};
use crevice::std140::AsStd140;
+use wgpu::{SamplerBindingType};
pub struct SpritePipeline {
view_layout: BindGroupLayout,
@@ -66,10 +67,7 @@
BindGroupLayoutEntry {
binding: 1,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
],
@@ -140,8 +138,8 @@
primitive: PrimitiveState {
front_face: FrontFace::Ccw,
cull_mode: None,
+ unclipped_depth: false,
polygon_mode: PolygonMode::Fill,
- clamp_depth: false,
conservative: false,
topology: PrimitiveTopology::TriangleList,
strip_index_format: None,
@@ -351,7 +349,7 @@
handle: current_batch_handle.clone_weak(),
z: last_z,
colored: true,
- },));
+ }, ));
colored_start = colored_end;
} else {
commands.spawn_bundle((SpriteBatch {
@@ -359,7 +357,7 @@
handle: current_batch_handle.clone_weak(),
z: last_z,
colored: false,
- },));
+ }, ));
start = end;
}
}
@@ -447,7 +445,7 @@
handle: current_batch_handle,
colored: false,
z: last_z,
- },));
+ }, ));
}
} else if colored_start != colored_end {
if let Some(current_batch_handle) = current_batch_handle {
@@ -456,7 +454,7 @@
handle: current_batch_handle,
colored: true,
z: last_z,
- },));
+ }, ));
}
}
Index: crates/bevy_pbr/src/render/mesh.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/src/render/mesh.rs b/crates/bevy_pbr/src/render/mesh.rs
--- a/crates/bevy_pbr/src/render/mesh.rs (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/src/render/mesh.rs (date 1639856841391)
@@ -23,10 +23,7 @@
};
use bevy_transform::components::GlobalTransform;
use crevice::std140::AsStd140;
-use wgpu::{
- Extent3d, ImageCopyTexture, ImageDataLayout, Origin3d, TextureDimension, TextureFormat,
- TextureViewDescriptor,
-};
+use wgpu::{Extent3d, ImageCopyTexture, ImageDataLayout, Origin3d, SamplerBindingType, TextureDimension, TextureFormat, TextureViewDescriptor};
#[derive(Default)]
pub struct MeshRenderPlugin;
@@ -210,10 +207,7 @@
BindGroupLayoutEntry {
binding: 3,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: true,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
// Directional Shadow Texture Array
@@ -231,10 +225,7 @@
BindGroupLayoutEntry {
binding: 5,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: true,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
// PointLights
@@ -493,8 +484,8 @@
primitive: PrimitiveState {
front_face: FrontFace::Ccw,
cull_mode: Some(Face::Back),
+ unclipped_depth: false,
polygon_mode: PolygonMode::Fill,
- clamp_depth: false,
conservative: false,
topology: PrimitiveTopology::TriangleList,
strip_index_format: None,
Index: crates/bevy_render/src/render_resource/pipeline_cache.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_render/src/render_resource/pipeline_cache.rs b/crates/bevy_render/src/render_resource/pipeline_cache.rs
--- a/crates/bevy_render/src/render_resource/pipeline_cache.rs (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_render/src/render_resource/pipeline_cache.rs (date 1639855523900)
@@ -339,6 +339,7 @@
};
let descriptor = RawRenderPipelineDescriptor {
+ multiview: None,
depth_stencil: descriptor.depth_stencil.clone(),
label: descriptor.label.as_deref(),
layout,
Index: crates/bevy_pbr/src/render/mod.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/src/render/mod.rs b/crates/bevy_pbr/src/render/mod.rs
--- a/crates/bevy_pbr/src/render/mod.rs (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/src/render/mod.rs (date 1639855748231)
@@ -1,6 +1,7 @@
mod light;
mod mesh;
+use wgpu::SamplerBindingType;
pub use light::*;
pub use mesh::*;
@@ -81,10 +82,7 @@
BindGroupLayoutEntry {
binding: 2,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
// Emissive Texture
@@ -102,10 +100,7 @@
BindGroupLayoutEntry {
binding: 4,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
// Metallic Roughness Texture
@@ -123,10 +118,7 @@
BindGroupLayoutEntry {
binding: 6,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
// Occlusion Texture
@@ -144,10 +136,7 @@
BindGroupLayoutEntry {
binding: 8,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
// Normal Map Texture
@@ -165,10 +154,7 @@
BindGroupLayoutEntry {
binding: 10,
visibility: ShaderStages::FRAGMENT,
- ty: BindingType::Sampler {
- comparison: false,
- filtering: true,
- },
+ ty: BindingType::Sampler(SamplerBindingType::Filtering),
count: None,
},
],
Index: crates/bevy_render/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_render/Cargo.toml b/crates/bevy_render/Cargo.toml
--- a/crates/bevy_render/Cargo.toml (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_render/Cargo.toml (date 1639855418840)
@@ -36,7 +36,7 @@
image = { version = "0.23.12", default-features = false }
# misc
-wgpu = { version = "0.11.0", features = ["spirv"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", features = ["spirv"] }
naga = { version = "0.7.0", features = ["glsl-in", "spv-in", "spv-out", "wgsl-in", "wgsl-out"] }
serde = { version = "1", features = ["derive"] }
bitflags = "1.2.1"
@@ -53,4 +53,4 @@
crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
[target.'cfg(target_arch = "wasm32")'.dependencies]
-wgpu = { version = "0.11.0", features = ["spirv", "webgl"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", features = ["spirv", "webgl"] }
Index: crates/crevice/crevice-tests/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/crevice/crevice-tests/Cargo.toml b/crates/crevice/crevice-tests/Cargo.toml
--- a/crates/crevice/crevice-tests/Cargo.toml (revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/crevice/crevice-tests/Cargo.toml (date 1639855418832)
@@ -17,4 +17,4 @@
futures = { version = "0.3.17", features = ["executor"], optional = true }
naga = { version = "0.7.0", features = ["glsl-in", "wgsl-out"], optional = true }
-wgpu = { version = "0.11.0", optional = true }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", optional = true } |
On my PC it uses Vulkan backend. |
I have removed |
Thanks for the report! This is definitely a duplicate of #3352. Lets move the conversation there. (edit: oops hit enter too early) |
Ooh |
wgpu prefers Vulkan currently. You may end up with a DX12 adapter if the adapters of Vulkan do not meet the |
Awesome. Thanks! |
@Elabajaba what does |
@cart as of gpu-z report Vulkan is supported on my machine. I think wgpu chooses Dx12 because my gpu determined as discrete on Dx12 and integrated on Vulkan (have no idea why it does it) |
What is the adapter info printed to the console when you run with vulkan? |
@cart |
It could be seen as a bug in wgpu if the same physical adapter is classified differently in different APIs. |
Bevy version
b5a0453
Operating system & version
Windows 11 Dev 22518
What you did
cargo run --example bevymark
What you expected to happen
Bevy mark ran.
What actually happened
Panic
Additional information
logs:
GPU:
CPU:
cargo -V:
cargo 1.57.0 (b2e52d7ca 2021-10-21)
rustup default:
stable-x86_64-pc-windows-msvc (default)
The text was updated successfully, but these errors were encountered: