Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on AMD Radeon laptop gpu with Windows 11 #3373

Closed
vabka opened this issue Dec 18, 2021 · 16 comments
Closed

Panic on AMD Radeon laptop gpu with Windows 11 #3373

vabka opened this issue Dec 18, 2021 · 16 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash

Comments

@vabka
Copy link
Contributor

vabka commented Dec 18, 2021

Bevy version

b5a0453

Operating system & version

Windows 11 Dev 22518

What you did

cargo run --example bevymark

What you expected to happen

Bevy mark ran.

What actually happened

Panic

Additional information

logs:

2021-12-18T19:11:48.051449Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon(TM) Graphics", vendor: 4098, device: 5686, device_type: DiscreteGpu, backend: Dx12 }
2021-12-18T19:11:48.051825Z ERROR wgpu::backend::direct: Error in Adapter::request_device: unsupported features were requested: TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: RequestDeviceError', crates\bevy_render\src\renderer\mod.rs:91:10
stack backtrace:
   0:     0x7ff7a19e964f - std::backtrace_rs::backtrace::dbghelp::trace
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\..\..\backtrace\src\backtrace\dbghelp.rs:98
   1:     0x7ff7a19e964f - std::backtrace_rs::backtrace::trace_unsynchronized
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2:     0x7ff7a19e964f - std::sys_common::backtrace::_print_fmt
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:67
   3:     0x7ff7a19e964f - std::sys_common::backtrace::_print::impl$0::fmt
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:46
   4:     0x7ff7a1a0216a - core::fmt::write
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\core\src\fmt\mod.rs:1163
   5:     0x7ff7a19e5348 - std::io::Write::write_fmt<std::sys::windows::stdio::Stderr>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\io\mod.rs:1696
   6:     0x7ff7a19ec2c6 - std::sys_common::backtrace::_print
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:49
   7:     0x7ff7a19ec2c6 - std::sys_common::backtrace::print
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:36
   8:     0x7ff7a19ec2c6 - std::panicking::default_hook::closure$1
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:210
   9:     0x7ff7a19ebcc7 - std::panicking::default_hook
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:227
  10:     0x7ff7a19ec925 - std::panicking::rust_panic_with_hook
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:624
  11:     0x7ff7a19ec50b - std::panicking::begin_panic_handler::closure$0
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:521
  12:     0x7ff7a19e9f77 - std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure$0,never$>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:139
  13:     0x7ff7a19ec469 - std::panicking::begin_panic_handler
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:517
  14:     0x7ff7a1a13150 - core::panicking::panic_fmt
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\core\src\panicking.rs:100
  15:     0x7ff7a1a13263 - core::result::unwrap_failed
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\core\src\result.rs:1616
  16:     0x7ff7a06f8b6a - enum$<core::result::Result<tuple$<wgpu::Device,wgpu::Queue>,wgpu::RequestDeviceError>, 1, 18446744073709551615, Ok>::unwrap<tuple$<wgpu::Device,wgpu::Queue>,wgpu::RequestDeviceError>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\result.rs:1298
  17:     0x7ff7a0842148 - bevy_render::renderer::initialize_renderer::generator$0
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\renderer\mod.rs:88
  18:     0x7ff7a087b2cf - core::future::from_generator::impl$1::poll<bevy_render::renderer::initialize_renderer::generator$0>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\future\mod.rs:80
  19:     0x7ff7a0840c7c - futures_lite::future::block_on::closure$0<tuple$<bevy_render::renderer::render_device::RenderDevice,alloc::sync::Arc<wgpu::Queue> >,core::future::from_generator::GenFuture<bevy_render::renderer::initialize_renderer::generator$0> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-lite-1.12.0\src\future.rs:89
  20:     0x7ff7a0893d03 - std::thread::local::LocalKey<core::cell::RefCell<tuple$<parking::Parker,core::task::wake::Waker> > >::try_with<core::cell::RefCell<tuple$<parking::Parker,core::task::wake::Waker> >,futures_lite::future::block_on::closure$0,tuple$<bevy_render::renderer::re
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\thread\local.rs:399
  21:     0x7ff7a0893843 - std::thread::local::LocalKey<core::cell::RefCell<tuple$<parking::Parker,core::task::wake::Waker> > >::with<core::cell::RefCell<tuple$<parking::Parker,core::task::wake::Waker> >,futures_lite::future::block_on::closure$0,tuple$<bevy_render::renderer::render
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\thread\local.rs:375
  22:     0x7ff7a0840a1a - futures_lite::future::block_on<tuple$<bevy_render::renderer::render_device::RenderDevice,alloc::sync::Arc<wgpu::Queue> >,core::future::from_generator::GenFuture<bevy_render::renderer::initialize_renderer::generator$0> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-lite-1.12.0\src\future.rs:79
  23:     0x7ff7a06a5de0 - bevy_render::impl$2::build
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\lib.rs:125
  24:     0x7ff7a17b0721 - bevy_app::plugin_group::PluginGroupBuilder::finish
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_app\src\plugin_group.rs:104
  25:     0x7ff79febd2e3 - bevy_app::app::App::add_plugins<bevy_internal::default_plugins::DefaultPlugins>
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_app\src\app.rs:782
  26:     0x7ff79feb924c - bevymark::main
                               at C:\Users\Vabka\CLionProjects\bevy\examples\tools\bevymark.rs:25
  27:     0x7ff79feb340b - core::ops::function::FnOnce::call_once<void (*)(),tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:227
  28:     0x7ff79feb6e6b - std::sys_common::backtrace::__rust_begin_short_backtrace<void (*)(),tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\sys_common\backtrace.rs:123
  29:     0x7ff79febeba1 - std::rt::lang_start::closure$0<tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\rt.rs:146
  30:     0x7ff7a19e913b - core::ops::function::impls::impl$2::call_once
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:259
  31:     0x7ff7a19e913b - std::panicking::try::do_call
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:403
  32:     0x7ff7a19e913b - std::panicking::try
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:367
  33:     0x7ff7a19e913b - std::panic::catch_unwind
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panic.rs:133
  34:     0x7ff7a19e913b - std::rt::lang_start_internal::closure$2
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\rt.rs:128
  35:     0x7ff7a19e913b - std::panicking::try::do_call
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:403
  36:     0x7ff7a19e913b - std::panicking::try
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:367
  37:     0x7ff7a19e913b - std::panic::catch_unwind
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panic.rs:133
  38:     0x7ff7a19e913b - std::rt::lang_start_internal
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\rt.rs:128
  39:     0x7ff79febeb6f - std::rt::lang_start<tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\rt.rs:145
  40:     0x7ff79febc686 - main
  41:     0x7ff7a1a11414 - invoke_main
                               at d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78
  42:     0x7ff7a1a11414 - __scrt_common_main_seh
                               at d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
  43:     0x7fffccfc1350 - BaseThreadInitThunk
  44:     0x7fffce492e78 - RtlUserThreadStart
error: process didn't exit successfully: `target\debug\examples\bevymark.exe` (exit code: 101)

GPU:
image
CPU:
image
cargo -V:
cargo 1.57.0 (b2e52d7ca 2021-10-21)
rustup default:
stable-x86_64-pc-windows-msvc (default)

@vabka vabka added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 18, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash and removed S-Needs-Triage This issue needs to be labelled labels Dec 18, 2021
@DJMcNab
Copy link
Member

DJMcNab commented Dec 18, 2021

Possibly duplicate of #3352, #3352 ?

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

@DJMcNab looks simillar.

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

Update to latest version of wgpu with git did not helped (after fixing compilation errors)

2021-12-18T19:44:20.311449Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon(TM) Graphics", vendor: 4098, device: 5686, device_type: DiscreteGpu, backend: Dx12 }
2021-12-18T19:44:21.350672Z ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default
thread 'main' panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_shader_module

Shader '' parsing error: unknown attribute: 'block'
  ┌─ wgsl:1:3
  │
1 │ [[block]]
  │   ^^^^^ unknown attribute


    unknown attribute: 'block'

', C:\Users\Vabka\.cargo\git\checkouts\wgpu-53e70f8674b08dd4\c00e471\wgpu\src\backend\direct.rs:2273:5
stack backtrace:
   0:     0x7ff71f7b7eaf - std::backtrace_rs::backtrace::dbghelp::trace
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\..\..\backtrace\src\backtrace\dbghelp.rs:98
   1:     0x7ff71f7b7eaf - std::backtrace_rs::backtrace::trace_unsynchronized
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2:     0x7ff71f7b7eaf - std::sys_common::backtrace::_print_fmt
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:67
   3:     0x7ff71f7b7eaf - std::sys_common::backtrace::_print::impl$0::fmt
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:46
   4:     0x7ff71f7d09ca - core::fmt::write
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\core\src\fmt\mod.rs:1163
   5:     0x7ff71f7b3ba8 - std::io::Write::write_fmt<std::sys::windows::stdio::Stderr>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\io\mod.rs:1696
   6:     0x7ff71f7bab26 - std::sys_common::backtrace::_print
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:49
   7:     0x7ff71f7bab26 - std::sys_common::backtrace::print
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:36
   8:     0x7ff71f7bab26 - std::panicking::default_hook::closure$1
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:210
   9:     0x7ff71f7ba527 - std::panicking::default_hook
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:227
  10:     0x7ff71f7bb185 - std::panicking::rust_panic_with_hook
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:624
  11:     0x7ff71f7bad6b - std::panicking::begin_panic_handler::closure$0
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:521
  12:     0x7ff71f7b87d7 - std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure$0,never$>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\sys_common\backtrace.rs:139
  13:     0x7ff71f7bacc9 - std::panicking::begin_panic_handler
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:517
  14:     0x7ff71f7e119c - std::panicking::begin_panic_fmt
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:460
  15:     0x7ff71e82db99 - wgpu::backend::direct::default_error_handler
                               at C:\Users\Vabka\.cargo\git\checkouts\wgpu-53e70f8674b08dd4\c00e471\wgpu\src\backend\direct.rs:2273
  16:     0x7ff71e800b5d - core::ops::function::Fn::call<void (*)(enum$<wgpu::Error>),tuple$<enum$<wgpu::Error> > >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:70
  17:     0x7ff71e81de34 - alloc::boxed::impl$46::call<tuple$<enum$<wgpu::Error> >,dyn$<wgpu::UncapturedErrorHandler,assoc$<Output,tuple$<> > > >,alloc::alloc::Global>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\alloc\src\boxed.rs:1705
  18:     0x7ff71e82d8f2 - wgpu::backend::direct::ErrorSinkRaw::handle_error
                               at C:\Users\Vabka\.cargo\git\checkouts\wgpu-53e70f8674b08dd4\c00e471\wgpu\src\backend\direct.rs:2259
  19:     0x7ff71e824c79 - wgpu::backend::direct::Context::handle_error<enum$<wgpu_core::pipeline::CreateShaderModuleError> >
                               at C:\Users\Vabka\.cargo\git\checkouts\wgpu-53e70f8674b08dd4\c00e471\wgpu\src\backend\direct.rs:194
  20:     0x7ff71e827c7f - wgpu::backend::direct::impl$3::device_create_shader_module
                               at C:\Users\Vabka\.cargo\git\checkouts\wgpu-53e70f8674b08dd4\c00e471\wgpu\src\backend\direct.rs:1047
  21:     0x7ff71e78b87f - wgpu::Device::create_shader_module
                               at C:\Users\Vabka\.cargo\git\checkouts\wgpu-53e70f8674b08dd4\c00e471\wgpu\src\lib.rs:1705
  22:     0x7ff71e2c98ec - bevy_render::renderer::render_device::RenderDevice::create_shader_module
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\renderer\render_device.rs:41
  23:     0x7ff71e2c281f - bevy_render::render_resource::pipeline_cache::ShaderCache::get
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\render_resource\pipeline_cache.rs:73
  24:     0x7ff71e2c43bb - bevy_render::render_resource::pipeline_cache::RenderPipelineCache::process_queue
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\render_resource\pipeline_cache.rs:287
  25:     0x7ff71e2c4f58 - bevy_render::render_resource::pipeline_cache::RenderPipelineCache::process_pipeline_queue_system
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\render_resource\pipeline_cache.rs:368
  26:     0x7ff71e216c1d - core::ops::function::FnMut::call_mut<void (*)(bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPipelineCache>),tuple$<bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPipelineCach
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:150
  27:     0x7ff71e30658e - core::ops::function::impls::impl$3::call_mut<tuple$<bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPipelineCache> >,void (*)(bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPip
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:269
  28:     0x7ff71e40c6e2 - bevy_ecs::system::function_system::impl$10::run::call_inner<tuple$<>,bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPipelineCache>,ref_mut$<void (*)(bevy_ecs::change_detection::ResMut<bevy_render::render_resource::p
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_ecs\src\system\function_system.rs:512
  29:     0x7ff71e3061ca - bevy_ecs::system::function_system::impl$10::run<tuple$<>,void (*)(bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPipelineCache>),bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::Rende
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_ecs\src\system\function_system.rs:515
  30:     0x7ff71e4102a7 - bevy_ecs::system::function_system::impl$7::run_unsafe<tuple$<>,tuple$<>,tuple$<bevy_ecs::change_detection::ResMut<bevy_render::render_resource::pipeline_cache::RenderPipelineCache> >,tuple$<>,void (*)(bevy_ecs::change_detection::ResMut<bevy_render::render
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_ecs\src\system\function_system.rs:442
  31:     0x7ff71f6422c0 - bevy_ecs::schedule::executor_parallel::impl$2::prepare_systems::generator$0
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_ecs\src\schedule\executor_parallel.rs:204
  32:     0x7ff71f665d39 - core::future::from_generator::impl$1::poll<bevy_ecs::schedule::executor_parallel::impl$2::prepare_systems::generator$0>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\future\mod.rs:80
  33:     0x7ff71f5fca69 - async_executor::impl$4::spawn::generator$0<tuple$<>,core::future::from_generator::GenFuture<bevy_ecs::schedule::executor_parallel::impl$2::prepare_systems::generator$0> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\async-executor-1.4.1\src\lib.rs:144
  34:     0x7ff71f6661f9 - core::future::from_generator::impl$1::poll<async_executor::impl$4::spawn::generator$0>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\future\mod.rs:80
  35:     0x7ff71f64a8e5 - async_task::raw::RawTask<core::future::from_generator::GenFuture<async_executor::impl$4::spawn::generator$0>,tuple$<>,async_executor::impl$4::schedule::closure$0>::run<core::future::from_generator::GenFuture<async_executor::impl$4::spawn::generator$0>,tup
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\async-task-4.0.3\src\raw.rs:489
  36:     0x7ff71f697471 - async_task::runnable::Runnable::run
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\async-task-4.0.3\src\runnable.rs:309
  37:     0x7ff71f686bae - async_executor::Executor::try_tick
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\async-executor-1.4.1\src\lib.rs:181
  38:     0x7ff71f6694f4 - bevy_tasks::task_pool::impl$2::scope::closure$0<bevy_ecs::schedule::executor_parallel::impl$1::run_systems::closure$1,tuple$<> >
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_tasks\src\task_pool.rs:222
  39:     0x7ff71f66a3a6 - std::thread::local::LocalKey<async_executor::LocalExecutor>::try_with<async_executor::LocalExecutor,bevy_tasks::task_pool::impl$2::scope::closure$0,alloc::vec::Vec<tuple$<>,alloc::alloc::Global> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\thread\local.rs:399
  40:     0x7ff71f66a16f - std::thread::local::LocalKey<async_executor::LocalExecutor>::with<async_executor::LocalExecutor,bevy_tasks::task_pool::impl$2::scope::closure$0,alloc::vec::Vec<tuple$<>,alloc::alloc::Global> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\thread\local.rs:375
  41:     0x7ff71f6691aa - bevy_tasks::task_pool::TaskPool::scope<bevy_ecs::schedule::executor_parallel::impl$1::run_systems::closure$1,tuple$<> >
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_tasks\src\task_pool.rs:169
  42:     0x7ff71f656366 - bevy_ecs::schedule::executor_parallel::impl$1::run_systems
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_ecs\src\schedule\executor_parallel.rs:120
  43:     0x7ff71f5c8bdf - bevy_ecs::schedule::stage::impl$1::run
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_ecs\src\schedule\stage.rs:850
  44:     0x7ff71e2bdde6 - bevy_render::impl$2::build::closure$2
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_render\src\lib.rs:262
  45:     0x7ff71f587ffd - alloc::boxed::impl$46::call<tuple$<ref_mut$<bevy_ecs::world::World>,ref_mut$<bevy_app::app::App> >,dyn$<core::ops::function::Fn<tuple$<ref_mut$<bevy_ecs::world::World>,ref_mut$<bevy_app::app::App> >,assoc$<Output,tuple$<> > > >,alloc::alloc::Global>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\alloc\src\boxed.rs:1705
  46:     0x7ff71f57ed17 - bevy_app::app::App::update
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_app\src\app.rs:99
  47:     0x7ff71da79d08 - bevy_winit::winit_runner_with::closure$1
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_winit\src\lib.rs:500
  48:     0x7ff71dabc4f1 - winit::platform_impl::platform::event_loop::impl$2::run_return::closure$0<tuple$<>,bevy_winit::winit_runner_with::closure$1>
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:206
  49:     0x7ff71daffb84 - alloc::boxed::impl$45::call_mut<tuple$<enum$<winit::event::Event<tuple$<> > >,ref_mut$<enum$<winit::event_loop::ControlFlow> > >,dyn$<core::ops::function::FnMut<tuple$<enum$<winit::event::Event<tuple$<> > >,ref_mut$<enum$<winit::event_loop::ControlFlow> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\alloc\src\boxed.rs:1698
  50:     0x7ff71db29cc3 - winit::platform_impl::platform::event_loop::runner::impl$3::call_event_handler::closure$0<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop\runner.rs:245
  51:     0x7ff71db21804 - core::panic::unwind_safe::impl$23::call_once<tuple$<>,winit::platform_impl::platform::event_loop::runner::impl$3::call_event_handler::closure$0>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\panic\unwind_safe.rs:271
  52:     0x7ff71db21d21 - std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::runner::impl$3::call_event_handler::closure$0>,tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\panicking.rs:403
  53:     0x7ff71db24eb3 - winit::platform_impl::platform::raw_input::get_raw_mouse_button_state
  54:     0x7ff71db21c5b - std::panicking::try<tuple$<>,core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::runner::impl$3::call_event_handler::closure$0> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\panicking.rs:367
  55:     0x7ff71daf0724 - std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::runner::impl$3::call_event_handler::closure$0>,tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\panic.rs:133
  56:     0x7ff71db29182 - winit::platform_impl::platform::event_loop::runner::EventLoopRunner<tuple$<> >::catch_unwind<tuple$<>,tuple$<>,winit::platform_impl::platform::event_loop::runner::impl$3::call_event_handler::closure$0>
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop\runner.rs:152
  57:     0x7ff71db29a53 - winit::platform_impl::platform::event_loop::runner::EventLoopRunner<tuple$<> >::call_event_handler<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop\runner.rs:239
  58:     0x7ff71db2a3cc - winit::platform_impl::platform::event_loop::runner::EventLoopRunner<tuple$<> >::move_state_to<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop\runner.rs:341
  59:     0x7ff71db299e7 - winit::platform_impl::platform::event_loop::runner::EventLoopRunner<tuple$<> >::main_events_cleared<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop\runner.rs:227
  60:     0x7ff71db1036d - winit::platform_impl::platform::event_loop::flush_paint_messages<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:726
  61:     0x7ff71dac3a83 - winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:941
  62:     0x7ff71da7d2d7 - core::ops::function::FnOnce::call_once<winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0,tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:227
  63:     0x7ff71daefed1 - core::panic::unwind_safe::impl$23::call_once<isize,winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\panic\unwind_safe.rs:271
  64:     0x7ff71daefae0 - std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0>,isize>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\panicking.rs:403
  65:     0x7ff71daefca3 - std::panicking::try::do_catch<core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0>,isize>
  66:     0x7ff71daef7dc - std::panicking::try<isize,core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\panicking.rs:367
  67:     0x7ff71daeefed - std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0>,isize>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\panic.rs:133
  68:     0x7ff71dae881c - winit::platform_impl::platform::event_loop::runner::EventLoopRunner<tuple$<> >::catch_unwind<tuple$<>,isize,winit::platform_impl::platform::event_loop::public_window_callback_inner::closure$0>
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop\runner.rs:152
  69:     0x7ff71dabde6c - winit::platform_impl::platform::event_loop::public_window_callback_inner<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:2030
  70:     0x7ff71dabc8bd - winit::platform_impl::platform::event_loop::public_window_callback<tuple$<> >
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:846
  71:     0x7fffcda4aa73 - CallWindowProcW
  72:     0x7fffcda4a43c - SendMessageW
  73:     0x7fffcda57d5a - FillRect
  74:     0x7fffce4e6834 - KiUserCallbackDispatcher
  75:     0x7fffcbb91ad4 - NtUserDispatchMessage
  76:     0x7fffcda4912e - DispatchMessageW
  77:     0x7ff71dabc210 - winit::platform_impl::platform::event_loop::EventLoop<tuple$<> >::run_return<tuple$<>,bevy_winit::winit_runner_with::closure$1>
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:221
  78:     0x7ff71dabc5bf - winit::platform_impl::platform::event_loop::EventLoop<tuple$<> >::run<tuple$<>,bevy_winit::winit_runner_with::closure$1>
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\platform_impl\windows\event_loop.rs:191
  79:     0x7ff71da9e2f5 - winit::event_loop::EventLoop<tuple$<> >::run<tuple$<>,bevy_winit::winit_runner_with::closure$1>
                               at C:\Users\Vabka\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.26.0\src\event_loop.rs:154
  80:     0x7ff71da79975 - bevy_winit::run<bevy_winit::winit_runner_with::closure$1>
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_winit\src\lib.rs:167
  81:     0x7ff71da78304 - bevy_winit::winit_runner_with
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_winit\src\lib.rs:509
  82:     0x7ff71da77db4 - bevy_winit::winit_runner
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_winit\src\lib.rs:207
  83:     0x7ff71da7cb73 - core::ops::function::Fn::call<void (*)(bevy_app::app::App),tuple$<bevy_app::app::App> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:70
  84:     0x7ff71f587fba - alloc::boxed::impl$46::call<tuple$<bevy_app::app::App>,dyn$<core::ops::function::Fn<tuple$<bevy_app::app::App>,assoc$<Output,tuple$<> > > >,alloc::alloc::Global>
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\alloc\src\boxed.rs:1705
  85:     0x7ff71f57ee15 - bevy_app::app::App::run
                               at C:\Users\Vabka\CLionProjects\bevy\crates\bevy_app\src\app.rs:115
  86:     0x7ff71da59b56 - bevymark::main
                               at C:\Users\Vabka\CLionProjects\bevy\examples\tools\bevymark.rs:25
  87:     0x7ff71da6081b - core::ops::function::FnOnce::call_once<void (*)(),tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:227
  88:     0x7ff71da5165b - std::sys_common::backtrace::__rust_begin_short_backtrace<void (*)(),tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\sys_common\backtrace.rs:123
  89:     0x7ff71da68a51 - std::rt::lang_start::closure$0<tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\rt.rs:146
  90:     0x7ff71f7b799b - core::ops::function::impls::impl$2::call_once
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:259
  91:     0x7ff71f7b799b - std::panicking::try::do_call
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:403
  92:     0x7ff71f7b799b - std::panicking::try
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:367
  93:     0x7ff71f7b799b - std::panic::catch_unwind
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panic.rs:133
  94:     0x7ff71f7b799b - std::rt::lang_start_internal::closure$2
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\rt.rs:128
  95:     0x7ff71f7b799b - std::panicking::try::do_call
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:403
  96:     0x7ff71f7b799b - std::panicking::try
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:367
  97:     0x7ff71f7b799b - std::panic::catch_unwind
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panic.rs:133
  98:     0x7ff71f7b799b - std::rt::lang_start_internal
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\rt.rs:128
  99:     0x7ff71da68a1f - std::rt::lang_start<tuple$<> >
                               at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\std\src\rt.rs:145
 100:     0x7ff71da5ceb6 - main
 101:     0x7ff71f7dfc74 - invoke_main
                               at d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78
 102:     0x7ff71f7dfc74 - __scrt_common_main_seh
                               at d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
 103:     0x7fffccfc1350 - BaseThreadInitThunk
 104:     0x7fffce492e78 - RtlUserThreadStart
error: process didn't exit successfully: `target\debug\examples\bevymark.exe` (exit code: 101)

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

My changeset:

Index: crates/bevy_ui/src/render/pipeline.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_ui/src/render/pipeline.rs b/crates/bevy_ui/src/render/pipeline.rs
--- a/crates/bevy_ui/src/render/pipeline.rs	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_ui/src/render/pipeline.rs	(date 1639856841398)
@@ -4,6 +4,7 @@
 };
 
 use crevice::std140::AsStd140;
+use wgpu::{SamplerBindingType};
 
 pub struct UiPipeline {
     pub view_layout: BindGroupLayout,
@@ -44,10 +45,7 @@
                 BindGroupLayoutEntry {
                     binding: 1,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
             ],
@@ -114,8 +112,8 @@
             primitive: PrimitiveState {
                 front_face: FrontFace::Ccw,
                 cull_mode: None,
+                unclipped_depth: false,
                 polygon_mode: PolygonMode::Fill,
-                clamp_depth: false,
                 conservative: false,
                 topology: PrimitiveTopology::TriangleList,
                 strip_index_format: None,
Index: crates/bevy_ui/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_ui/Cargo.toml b/crates/bevy_ui/Cargo.toml
--- a/crates/bevy_ui/Cargo.toml	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_ui/Cargo.toml	(date 1639856545831)
@@ -29,7 +29,8 @@
 
 # other
 stretch = "0.3.2"
-serde = {version = "1", features = ["derive"]}
+serde = { version = "1", features = ["derive"] }
 smallvec = { version = "1.6", features = ["union", "const_generics"] }
 bytemuck = { version = "1.5", features = ["derive"] }
-crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
\ No newline at end of file
+crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu" }
\ No newline at end of file
Index: crates/bevy_sprite/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_sprite/Cargo.toml b/crates/bevy_sprite/Cargo.toml
--- a/crates/bevy_sprite/Cargo.toml	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_sprite/Cargo.toml	(date 1639856322021)
@@ -31,3 +31,4 @@
 thiserror = "1.0"
 rectangle-pack = "0.4"
 serde = { version = "1", features = ["derive"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu" }
\ No newline at end of file
Index: crates/bevy_pbr/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/Cargo.toml b/crates/bevy_pbr/Cargo.toml
--- a/crates/bevy_pbr/Cargo.toml	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/Cargo.toml	(date 1639855418822)
@@ -27,4 +27,4 @@
 # direct dependency required for derive macro
 bytemuck = { version = "1", features = ["derive"] }
 crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
-wgpu = { version = "0.11.0", features = ["spirv"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", features = ["spirv"] }
Index: crates/bevy_gltf/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_gltf/Cargo.toml b/crates/bevy_gltf/Cargo.toml
--- a/crates/bevy_gltf/Cargo.toml	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_gltf/Cargo.toml	(date 1639856399495)
@@ -29,4 +29,4 @@
 anyhow = "1.0.4"
 base64 = "0.13.0"
 percent-encoding = "2.1"
-wgpu = "0.11.0"
+wgpu = { git = "https://github.com/gfx-rs/wgpu" }
Index: crates/bevy_pbr/src/render/light.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/src/render/light.rs b/crates/bevy_pbr/src/render/light.rs
--- a/crates/bevy_pbr/src/render/light.rs	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/src/render/light.rs	(date 1639856841407)
@@ -293,8 +293,8 @@
                 strip_index_format: None,
                 front_face: FrontFace::Ccw,
                 cull_mode: None,
+                unclipped_depth: false,
                 polygon_mode: PolygonMode::Fill,
-                clamp_depth: false,
                 conservative: false,
             },
             depth_stencil: Some(DepthStencilState {
Index: crates/bevy_sprite/src/render/mod.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_sprite/src/render/mod.rs b/crates/bevy_sprite/src/render/mod.rs
--- a/crates/bevy_sprite/src/render/mod.rs	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_sprite/src/render/mod.rs	(date 1639856841383)
@@ -26,6 +26,7 @@
 use bevy_utils::HashMap;
 use bytemuck::{Pod, Zeroable};
 use crevice::std140::AsStd140;
+use wgpu::{SamplerBindingType};
 
 pub struct SpritePipeline {
     view_layout: BindGroupLayout,
@@ -66,10 +67,7 @@
                 BindGroupLayoutEntry {
                     binding: 1,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
             ],
@@ -140,8 +138,8 @@
             primitive: PrimitiveState {
                 front_face: FrontFace::Ccw,
                 cull_mode: None,
+                unclipped_depth: false,
                 polygon_mode: PolygonMode::Fill,
-                clamp_depth: false,
                 conservative: false,
                 topology: PrimitiveTopology::TriangleList,
                 strip_index_format: None,
@@ -351,7 +349,7 @@
                         handle: current_batch_handle.clone_weak(),
                         z: last_z,
                         colored: true,
-                    },));
+                    }, ));
                     colored_start = colored_end;
                 } else {
                     commands.spawn_bundle((SpriteBatch {
@@ -359,7 +357,7 @@
                         handle: current_batch_handle.clone_weak(),
                         z: last_z,
                         colored: false,
-                    },));
+                    }, ));
                     start = end;
                 }
             }
@@ -447,7 +445,7 @@
                 handle: current_batch_handle,
                 colored: false,
                 z: last_z,
-            },));
+            }, ));
         }
     } else if colored_start != colored_end {
         if let Some(current_batch_handle) = current_batch_handle {
@@ -456,7 +454,7 @@
                 handle: current_batch_handle,
                 colored: true,
                 z: last_z,
-            },));
+            }, ));
         }
     }
 
Index: crates/bevy_pbr/src/render/mesh.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/src/render/mesh.rs b/crates/bevy_pbr/src/render/mesh.rs
--- a/crates/bevy_pbr/src/render/mesh.rs	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/src/render/mesh.rs	(date 1639856841391)
@@ -23,10 +23,7 @@
 };
 use bevy_transform::components::GlobalTransform;
 use crevice::std140::AsStd140;
-use wgpu::{
-    Extent3d, ImageCopyTexture, ImageDataLayout, Origin3d, TextureDimension, TextureFormat,
-    TextureViewDescriptor,
-};
+use wgpu::{Extent3d, ImageCopyTexture, ImageDataLayout, Origin3d, SamplerBindingType, TextureDimension, TextureFormat, TextureViewDescriptor};
 
 #[derive(Default)]
 pub struct MeshRenderPlugin;
@@ -210,10 +207,7 @@
                 BindGroupLayoutEntry {
                     binding: 3,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: true,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
                 // Directional Shadow Texture Array
@@ -231,10 +225,7 @@
                 BindGroupLayoutEntry {
                     binding: 5,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: true,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
                 // PointLights
@@ -493,8 +484,8 @@
             primitive: PrimitiveState {
                 front_face: FrontFace::Ccw,
                 cull_mode: Some(Face::Back),
+                unclipped_depth: false,
                 polygon_mode: PolygonMode::Fill,
-                clamp_depth: false,
                 conservative: false,
                 topology: PrimitiveTopology::TriangleList,
                 strip_index_format: None,
Index: crates/bevy_render/src/render_resource/pipeline_cache.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_render/src/render_resource/pipeline_cache.rs b/crates/bevy_render/src/render_resource/pipeline_cache.rs
--- a/crates/bevy_render/src/render_resource/pipeline_cache.rs	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_render/src/render_resource/pipeline_cache.rs	(date 1639855523900)
@@ -339,6 +339,7 @@
             };
 
             let descriptor = RawRenderPipelineDescriptor {
+                multiview: None,
                 depth_stencil: descriptor.depth_stencil.clone(),
                 label: descriptor.label.as_deref(),
                 layout,
Index: crates/bevy_pbr/src/render/mod.rs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_pbr/src/render/mod.rs b/crates/bevy_pbr/src/render/mod.rs
--- a/crates/bevy_pbr/src/render/mod.rs	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_pbr/src/render/mod.rs	(date 1639855748231)
@@ -1,6 +1,7 @@
 mod light;
 mod mesh;
 
+use wgpu::SamplerBindingType;
 pub use light::*;
 pub use mesh::*;
 
@@ -81,10 +82,7 @@
                 BindGroupLayoutEntry {
                     binding: 2,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
                 // Emissive Texture
@@ -102,10 +100,7 @@
                 BindGroupLayoutEntry {
                     binding: 4,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
                 // Metallic Roughness Texture
@@ -123,10 +118,7 @@
                 BindGroupLayoutEntry {
                     binding: 6,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
                 // Occlusion Texture
@@ -144,10 +136,7 @@
                 BindGroupLayoutEntry {
                     binding: 8,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
                 // Normal Map Texture
@@ -165,10 +154,7 @@
                 BindGroupLayoutEntry {
                     binding: 10,
                     visibility: ShaderStages::FRAGMENT,
-                    ty: BindingType::Sampler {
-                        comparison: false,
-                        filtering: true,
-                    },
+                    ty: BindingType::Sampler(SamplerBindingType::Filtering),
                     count: None,
                 },
             ],
Index: crates/bevy_render/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/bevy_render/Cargo.toml b/crates/bevy_render/Cargo.toml
--- a/crates/bevy_render/Cargo.toml	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/bevy_render/Cargo.toml	(date 1639855418840)
@@ -36,7 +36,7 @@
 image = { version = "0.23.12", default-features = false }
 
 # misc
-wgpu = { version = "0.11.0", features = ["spirv"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", features = ["spirv"] }
 naga = { version = "0.7.0", features = ["glsl-in", "spv-in", "spv-out", "wgsl-in", "wgsl-out"] }
 serde = { version = "1", features = ["derive"] }
 bitflags = "1.2.1"
@@ -53,4 +53,4 @@
 crevice = { path = "../crevice", version = "0.8.0", features = ["glam"] }
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
-wgpu = { version = "0.11.0", features = ["spirv", "webgl"] }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", features = ["spirv", "webgl"] }
Index: crates/crevice/crevice-tests/Cargo.toml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/crates/crevice/crevice-tests/Cargo.toml b/crates/crevice/crevice-tests/Cargo.toml
--- a/crates/crevice/crevice-tests/Cargo.toml	(revision b5a04532c5c1cee266473b52ed5eaff2b851dfe8)
+++ b/crates/crevice/crevice-tests/Cargo.toml	(date 1639855418832)
@@ -17,4 +17,4 @@
 
 futures = { version = "0.3.17", features = ["executor"], optional = true }
 naga = { version = "0.7.0", features = ["glsl-in", "wgsl-out"], optional = true }
-wgpu = { version = "0.11.0", optional = true }
+wgpu = { git = "https://github.com/gfx-rs/wgpu", optional = true }

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

On my PC it uses Vulkan backend.
Why it uses Dx12 backend on laptop?
Maybe it is an issue?
UPD: Same on Vulkan

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

I have removed [[block]] and now it is working!
If found that this attribute is deprecated in WGSL, so i guess it is removed from wgpu

@cart
Copy link
Member

cart commented Dec 18, 2021

Thanks for the report! This is definitely a duplicate of #3352. Lets move the conversation there. (edit: oops hit enter too early)

@cart
Copy link
Member

cart commented Dec 18, 2021

Ooh [[block]] being deprecated makes me very happy. In reference to DX12 vs Vulkan on windows, I think I've bothered @kvark with this before but I forgot his answer. Does wgpu just favor DX12 over vulkan on windows, is it choosing it because it is "better" for a specific machine, or because Vulkan isn't available on a given machine?

@cart cart closed this as completed Dec 18, 2021
@kvark
Copy link

kvark commented Dec 18, 2021

wgpu prefers Vulkan currently. You may end up with a DX12 adapter if the adapters of Vulkan do not meet the request_adapter data. I.e. Vulkan may be exposing only NVidia dGPU, while DX12 may be exposing NVidia, Intel iGPU, and WARP implementation. So if you are requesting a "LowPower" adapter, it will give you DX12 Intel iGPU.

@cart
Copy link
Member

cart commented Dec 18, 2021

Awesome. Thanks!

@Elabajaba
Copy link
Contributor

@kvark for what it's worth, on my laptop that only has an AMD iGPU (Cezanne 5000 series with Vega 8), wgpu defaults to DX12 unless I force it to use Vulkan using the WGPU_BACKEND env variable on Windows 10.

Also duplicate of #3208

@kvark
Copy link

kvark commented Dec 18, 2021

@Elabajaba what does wgpu-info output looks like? (you can just clone the master repo and run cargo run in it to see).
Also, where does it default? Did you try running wgpu-rs examples?

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

@cart as of gpu-z report Vulkan is supported on my machine.
And it actually works if I set Backend to Vulkan manually in WgpuOptions.

I think wgpu chooses Dx12 because my gpu determined as discrete on Dx12 and integrated on Vulkan (have no idea why it does it)

@cart
Copy link
Member

cart commented Dec 18, 2021

What is the adapter info printed to the console when you run with vulkan?

@vabka
Copy link
Contributor Author

vabka commented Dec 18, 2021

@cart AdapterInfo { name: "AMD Radeon(TM) Graphics", vendor: 4098, device: 5686, device_type: IntegratedGpu, backend: Vulkan }

@kvark
Copy link

kvark commented Dec 19, 2021

It could be seen as a bug in wgpu if the same physical adapter is classified differently in different APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash
Projects
None yet
Development

No branches or pull requests

6 participants