Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pindel pin deps #4241

Merged
merged 4 commits into from
Mar 23, 2017
Merged

Pindel pin deps #4241

merged 4 commits into from
Mar 23, 2017

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Mar 22, 2017

  • I have read the guidelines above.
  • This PR adds a new recipe.
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Add htslib to the list of pinned libraries. Further, I have changed our travis setup such that linting only happens when recipes are filtered based on commits instead of the env matrix. Otherwise, any change in the env matrix leads to linting all recipes in the repository.

@johanneskoester
Copy link
Contributor Author

@bioconda/perl there is a perl-related error. Have you seen this before? Any idea why the bioperl recipe is triggered at all?

@martin-raden
Copy link
Contributor

mhh.. no idea why bioperl is triggered..

but seems to be more a travis problem rather than a perl issue?!

I triggered a restart of the build (without much hope)..

Had faced similar error messages some time ago but for a C++ recipe... but can not recall what (if) solved them. :/

@bgruening
Copy link
Member

We need to revert this PR: https://github.com/bioconda/bioconda-recipes/pull/2906/files
This is still a regression and the new bioperl broke a lot so we removed it from the channel. I don't have access to a real computer, maybe some of you can revert it?

@johanneskoester I still don't understand why this commit shows up in testing as this recipe was not touched.

@johanneskoester
Copy link
Contributor Author

Because this PR changes the environment matrix. Doing this triggers filtering all recipes based on presence in the channel. Since the package has been deleted from the channel, bioconda-utils will try to build it.

@johanneskoester
Copy link
Contributor Author

Ok, @bgruening, doing this now. Thanks!

@johanneskoester johanneskoester merged commit e67fcd9 into master Mar 23, 2017
@johanneskoester johanneskoester deleted the pindel-pin-deps branch March 23, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants