bump zlib requirement to be in sync with conda-forge #7385

bgruening · 2018-01-27T17:14:24Z

I have read the guidelines for bioconda recipes.
This PR adds a new recipe.
AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
This PR updates an existing recipe.
This PR does something else (explain below).

This PR bumps the zlib requirements to be in sync with conda-forge. I have also cleanup up a large chunk of recipes and included CONDA_ZLIB everywhere.

@daler I will cancel the CI as this is targeting bulk and I don't want to waste CI minutes on CCI.

daler · 2018-01-28T16:15:30Z

@bgruening thanks!

If we need to be careful about using minutes on CCI, then what is our mechanism for doing bulk updates? Should we run these on travis?

bgruening · 2018-01-28T16:21:59Z

@daler its not yet clear. I think no one can estimate of this is a real problem for us. Lets try to use the new setup in a normal way and see how it goes. I will try to restore the travis setup next week so we can always go back for a few days.

mbargull · 2018-01-28T20:01:09Z

Should we include an update of the htslib pinning with this to avoid unneeded rebuilds?
The htslib recipe was recently updated to 1.7.
It looks like the htslib pinning has been updated quickly after the latest updates (update 1.4, pin 1.4, update 1.5, pin 1.5, update+pin 1.6), so that it looks reasonable to me to continue that way. What do you think?

bgruening · 2018-01-28T20:21:46Z

Sure, I'm not sure I will find time in the next days, but will do my best.

bgruening · 2018-02-03T11:13:27Z

@daler @mbargull I added the htslib bump as well. Its weekend to I think a good time for keeping the CI busy. Anyone wants to merge?

mbargull · 2018-02-03T12:29:47Z

Do we want to get bioconda/bioconda-utils#264 in before this? That would enable us to remove some unnecessary pinnings. I'll review this PR shortly.

mbargull

Wow, that's a big one! Nice work

mbargull · 2018-02-03T14:13:56Z

recipes/abricate/0.5/meta.yaml

@@ -1,35 +1,35 @@
 package:
-  name: abricate


4-space indentation

mbargull · 2018-02-03T14:14:39Z

recipes/addrg/meta.yaml

@@ -5,7 +5,7 @@ package:
  version: {{ version }}

 build:
-  number: 0
+  number: 1


htslib is not pinned

mbargull · 2018-02-03T14:15:07Z

recipes/alfred/0.1.2/meta.yaml

@@ -11,7 +11,7 @@ source:
    - Makefile.patch

 build:
-  number: 1
+  number: 3


mbargull · 2018-02-03T14:15:14Z

recipes/alfred/meta.yaml

@@ -11,7 +11,7 @@ source:
    - Makefile.patch

 build:
-  number: 1
+  number: 3


mbargull · 2018-02-03T14:16:31Z

recipes/asn2gb/meta.yaml

@@ -16,7 +16,7 @@ source:
    sha256: 4b6ac3831061bc8f8c8adb011fe58c8741402a9c21c95af395aa98154c9ab775 # [linux]

 build:
-    number: 0
+    number: 1


pinning on run-only dep can be removed (needs bioconda/bioconda-utils#264 to make linter happy)

mbargull · 2018-02-03T14:36:52Z

recipes/snippy/3.0/meta.yaml

@@ -13,7 +13,7 @@ build:

 requirements:
  build:
-    - perl-threaded
+    - perl


needs build bump

I decided against this, it would not change anything, but with the next version bump people will have it easier.

mbargull · 2018-02-03T14:37:25Z

recipes/soapdenovo2-errorcorrection/meta.yaml

-  run:
-      - libgcc # [linux]
-      - zlib
+    build:


4-space indentation?

mbargull · 2018-02-03T14:37:53Z

recipes/variant-effect-predictor/meta.yaml

@@ -7,24 +7,24 @@ source:
  url: https://github.com/Ensembl/ensembl-tools/archive/release/87.zip

 build:
-  number: 0
+  number: 2


mbargull · 2018-02-03T14:38:27Z

recipes/variantbam/meta.yaml

-    - xz
-    - bzip2
-    - zlib
+    - xz {{CONDA_XZ}}*


needs build bump

mbargull · 2018-02-03T14:39:03Z

recipes/wub/meta.yaml

@@ -6,7 +6,7 @@ package:
  version: {{ version }}

 build:
-  number: 1
+  number: 2


htslib in not pinned

maybe this is needed, I will leave this to the maintainer

We just don't need to bump the build number here.

bgruening · 2018-02-03T16:03:45Z

@mbargull I need to leave now. I tried to fix the most urgent onces.

mbargull · 2018-02-03T22:08:01Z

I just tagged 0.12.1 on bioconda-utils and updated bioconda-common accordingly so that we can use the unpinned run-only requirements for this PR.

bgruening · 2018-02-03T22:09:24Z

@mbargull in bulk linting should be disabled, so I think we can proceed here as soon as you are ready :)

mbargull · 2018-02-03T22:28:09Z

Argh, right, straight to bulk -- forgot that already...

mbargull · 2018-02-03T22:45:14Z

To me, open questions are what version restrictions (if any) should be used for the run-only requirements in asn2gb, bcbio-nextgen, minvar (and subfolders).
But this needn't delay this PR, so feel free to merge!

bgruening · 2018-02-03T22:50:59Z

Thanks @mbargull for this great review - as usual! Lets see how things go over the night.

mbargull · 2018-02-03T22:57:34Z

~600 recipes (of which ~240, 40 %, are UCSC ones) -- that should take a while 😆. Nice work on your part as well!

mbargull · 2018-02-04T21:01:05Z

The Linux job still has some more ucsc-* packages to build before it'll start with the other ones -- so has still a couple more runs to go.
The macOS run finished with:

11:25:30 BIOCONDA ERROR BUILD SUMMARY: of 126 recipes, 18 failed and 40 were skipped. Details of recipes and environments follow.
11:25:30 BIOCONDA ERROR BUILD SUMMARY: while the entire build failed, the following recipes were built successfully:
recipes/vphaser2
recipes/sniffles
recipes/bamhash/1.0
recipes/bamhash/1.1
recipes/bam-readcount
recipes/sparseassembler
recipes/sparc
recipes/assemblyutility
recipes/dbg2olc
recipes/asn2gb
recipes/allegro
recipes/agg
recipes/addrg
recipes/vsearch
recipes/ucsc-wigtobigwig
recipes/ucsc-bedtobigbed
recipes/ucsc-bedgraphtobigwig
recipes/trimadap
recipes/spades
recipes/seqtk
recipes/seqtk/r82
recipes/samtools/0.1.14
recipes/samtools/0.1.13
recipes/samtools
recipes/samtools/0.1.12
recipes/samtools/1.1
recipes/samtools/1.0
recipes/ropebwt2
recipes/htsbox
recipes/emboss
recipes/embassy-phylip
recipes/dsk
recipes/short-read-connector
recipes/diamond/0.8.26
recipes/diamond/0.8.31
recipes/diamond/0.8.36
recipes/diamond/0.8.29
recipes/diamond/0.8.30
recipes/diamond/0.8.28
recipes/diamond/0.8.27
recipes/diamond/0.9.10
recipes/diamond
recipes/bwa
recipes/bwa/0.5.9
recipes/bwa/0.7.8
recipes/bwa/0.7.3a
recipes/blat
recipes/blast
recipes/genblastg
recipes/rgi/3.1.2
recipes/rgi/3.2.1
recipes/rgi/3.2.0
recipes/rgi/3.1.1
recipes/rmblast
recipes/bfc
recipes/fermi2
recipes/bedtools/2.26.0
recipes/bedtools/2.27.0
recipes/bedtools/2.27.1
recipes/bedtools/2.16.2
recipes/bedtools/2.25
recipes/bcftools/1.3
recipes/bcftools
recipes/bcftools/1.3.1
recipes/bambamc
recipes/abricate
recipes/abricate/0.4
recipes/abricate/0.5
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe squeakr-0.5-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe soapdenovo2-gapcloser-1.12-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe snoscan-0.9b-pl5.22.0_1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe prosic-2.1.0-gsl1.16_1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe preseq-2.0.2-gsl1.16_1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe perl-compress-raw-zlib-2.069-pl5.22.0_4.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe pandaseq-2.11-2.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe openslide-3.4.1-3.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe ngmlr-0.2.2-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe graphmap-0.5.2-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe fermi-1.1_r751_beta-pl5.22.0_2.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe dcmtk-3.6.1-5.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe breakdancer-1.4.5-2.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe aria2-1.23.0-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe samtools-0.1.17-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe samtools-0.1.19-3.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe bwa-0.6.2-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe bedtools-2.17.0-1.tar.bz2, environment CONDA_PY=27;CONDA_HTSLIB=1.7;CONDA_BOOST=1.64;CONDA_R=3.4.1;CONDA_PERL=5.22.0;CONDA_NPY=112;CONDA_NCURSES=5.9;CONDA_GSL=1.16;CONDA_GMP=5.1;CONDA_HDF5=1.8.17;MACOSX_DEPLOYMENT_TARGET=10.9;CONDA_ZLIB=1.2.11;CONDA_BZIP2=1.0;CONDA_XZ=5.2
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe perl-io-compress due to failed dependencies ['recipes/perl-compress-raw-zlib']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe smalt due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe emirge due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe prophyle due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe soapdenovo2 due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe pysamstats due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe transabyss due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe pybedtools due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19', 'recipes/bedtools/2.17.0']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe ariba due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe shorah due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe plastid due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe detonate due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe pysam due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe lumpy-sv due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe minvar due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19', 'recipes/bwa/0.6.2', 'recipes/bedtools/2.17.0']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe novobreak due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19', 'recipes/bwa/0.6.2']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe cgat-scripts due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19', 'recipes/bedtools/2.17.0']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe cooler due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe nucleoatac due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe rsem due to failed dependencies ['recipes/samtools/0.1.17', 'recipes/samtools/0.1.19']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe nanopolish due to failed dependencies ['recipes/bwa/0.6.2']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe discosnp due to failed dependencies ['recipes/bwa/0.6.2']
11:25:30 BIOCONDA ERROR BUILD SUMMARY: SKIPPED recipe fermikit due to failed dependencies ['recipes/bwa/0.6.2']
Exited with code 1

bgruening · 2018-02-04T21:19:48Z

Most of the once I have seen are due to llvm errors, I assume GCC will help in a few/most cases.

bgruening added 3 commits January 27, 2018 18:07

bump versoin number for new zlib version, add zlib ENV var

219d961

increase zlib dependency

895511c

pin zlib in ucsc template

3001cc1

bgruening mentioned this pull request Jan 27, 2018

Question about the conflict of current zlib pinning with newer Python #7350

Closed

bgruening mentioned this pull request Feb 1, 2018

Racon: Remove python and mummer run deps #6433

Merged

5 tasks

bgruening added 3 commits February 3, 2018 12:00

add missing htslib pinning

1c6aba7

incease htslib version

278f119

increase build number

4670651

mbargull requested changes Feb 3, 2018

View reviewed changes

bgruening added 2 commits February 3, 2018 16:53

fix review comments

dff78cd

a few more review comment fixes

33d8ab3

bgruening added 2 commits February 3, 2018 20:45

next round of fixes

28e8c2c

last lint fixes

56d2d51

wub: no need for rebuild

fc0e434

mbargull approved these changes Feb 3, 2018

View reviewed changes

bgruening merged commit 048986e into bulk Feb 3, 2018

bgruening deleted the zlib branch February 3, 2018 22:51

mbargull mentioned this pull request Feb 3, 2018

hera: fix CONDA_HTSLIB typo #7497

Merged

5 tasks

daviesrob mentioned this pull request Feb 9, 2018

Anaconda package conflict when installing 1.7 samtools/samtools#772

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump zlib requirement to be in sync with conda-forge #7385

bump zlib requirement to be in sync with conda-forge #7385

bgruening commented Jan 27, 2018 •

edited

Loading

daler commented Jan 28, 2018

bgruening commented Jan 28, 2018

mbargull commented Jan 28, 2018

bgruening commented Jan 28, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

mbargull left a comment

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

bgruening Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

mbargull Feb 3, 2018

bgruening Feb 3, 2018

mbargull Feb 3, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

mbargull commented Feb 3, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

mbargull commented Feb 4, 2018

bgruening commented Feb 4, 2018

bump zlib requirement to be in sync with conda-forge #7385

bump zlib requirement to be in sync with conda-forge #7385

Conversation

bgruening commented Jan 27, 2018 • edited Loading

daler commented Jan 28, 2018

bgruening commented Jan 28, 2018

mbargull commented Jan 28, 2018

bgruening commented Jan 28, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

mbargull left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

mbargull commented Feb 3, 2018

bgruening commented Feb 3, 2018

mbargull commented Feb 3, 2018

mbargull commented Feb 4, 2018

bgruening commented Feb 4, 2018

bgruening commented Jan 27, 2018 •

edited

Loading