Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP 347: OP_CAT in Tapscript #1525

Merged
merged 58 commits into from
May 6, 2024
Merged

BIP 347: OP_CAT in Tapscript #1525

merged 58 commits into from
May 6, 2024

Commits on Dec 11, 2023

  1. Create bip-???-cat.mediawiki

    @EthanHeilman
    EthanHeilman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    83ca57f View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Fixes typo 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f1169dd View commit details
    Browse the repository at this point in the history

  2. Better fits bitcoin style guide 

    "If an if only has a single-statement then-clause, it can appear on the same line as the if, without braces. In every other case, braces are required, and the then and else clauses must appear correctly indented on a new line."

Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    26e8e5f View commit details
    Browse the repository at this point in the history

  3. Grammar fix 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0335c9d View commit details
    Browse the repository at this point in the history

  4. Adds brackets 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3d31e5c View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Wording 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    bb725e6 View commit details
    Browse the repository at this point in the history

  2. Keeps past tense consistant 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9779dc9 View commit details
    Browse the repository at this point in the history

  3. Better phrasing 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c5d66d6 View commit details
    Browse the repository at this point in the history

  4. Phrasing 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    848352f View commit details
    Browse the repository at this point in the history

  5. Typo 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a2b0100 View commit details
    Browse the repository at this point in the history

  6. Removes space in ref 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    6a790ec View commit details
    Browse the repository at this point in the history

  7. Removes space in ref 

    Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    01db3ac View commit details
    Browse the repository at this point in the history

  8. Typos 

    TIL that it is "a one" rather than "an one"

Co-authored-by: kallewoof <kalle.alm@gmail.com>
    @EthanHeilman @kallewoof
    EthanHeilman and kallewoof committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    945e2a3 View commit details
    Browse the repository at this point in the history

  9. Prefer bytes to Bytes 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    7180c1c View commit details
    Browse the repository at this point in the history

  10. Increases conciseness and clarity 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    6f5a74d View commit details
    Browse the repository at this point in the history

  11. Lowercase bytes 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d4f85b1 View commit details
    Browse the repository at this point in the history

  12. Adds subsection header 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    beb5802 View commit details
    Browse the repository at this point in the history

  13. Use BSD-3 license

    @EthanHeilman
    EthanHeilman committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0a143d3 View commit details
    Browse the repository at this point in the history

  14. Code formatting 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    8219830 View commit details
    Browse the repository at this point in the history

  15. Code formatting 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0b8a7e4 View commit details
    Browse the repository at this point in the history

  16. Period to colon 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    77509f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Avoids designing or discussing how to add post-quantum commitments to… 

    … Bitcoin
    @EthanHeilman
    EthanHeilman committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    4f39e4b View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Lowercase the signatures

    @EthanHeilman
    EthanHeilman committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    97635f5 View commit details
    Browse the repository at this point in the history

  2. Italicize variables 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    e3dc3ba View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Better reference for OP_CAT removal

    @EthanHeilman
    EthanHeilman committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e492a90 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Add backwards compatibility section

    @0xBEEFCAF3
    0xBEEFCAF3 committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    785b11e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from 0xBEEFCAF3/patch-1 

    Add backwards compatibility section
    @EthanHeilman
    EthanHeilman committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e91621e View commit details
    Browse the repository at this point in the history

  3. specify the hex value of the opcode

    @EthanHeilman
    EthanHeilman committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    82fe9fc View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. add clarifying note about the current opcode 

    And some grammar + spelling cleanup
    @0xBEEFCAF3
    0xBEEFCAF3 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    ae68ef1 View commit details
    Browse the repository at this point in the history

  2. Notes that the opcode used is the same as the original cat opcode

    @EthanHeilman
    EthanHeilman committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    f9e100e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cat' into patch-1

    @0xBEEFCAF3
    0xBEEFCAF3 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    799dc0c View commit details
    Browse the repository at this point in the history

  4. rm comment on disabled CAT opcode

    @0xBEEFCAF3
    0xBEEFCAF3 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    2cec73a View commit details
    Browse the repository at this point in the history

  5. revert changes to abstract

    @0xBEEFCAF3
    0xBEEFCAF3 committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5dde7ea View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2 from 0xBEEFCAF3/patch-1 

    add clarifying note about the current opcode
    @EthanHeilman
    EthanHeilman committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    2b5ab3b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. update OP_CAT implementation

    @0xBEEFCAF3
    0xBEEFCAF3 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b349374 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge pull request #3 from 0xBEEFCAF3/cat 

    Update OP_CAT implementation code
    @EthanHeilman
    EthanHeilman committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    35641a8 View commit details
    Browse the repository at this point in the history

  2. Fixes broken mediawiki link

    @EthanHeilman
    EthanHeilman committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ac231a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Adds more acknowledgements

    @EthanHeilman
    EthanHeilman committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c235aa4 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Changes OP_CAT BIP based on feedback given by Bob Summerwill 

    Bob Summerwill proposed a number of changes to the OP_CAT BIP to better follow BIP-2. This commit makes these changes:

* Using the section order specified in BIP-2
* Adding a Rationale section
* Expand the specification section by moving details from the abstract into the specification

Additionally this commit as rewords some confusing language.

Thanks Bob
    @EthanHeilman
    EthanHeilman committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f8ad6ed View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Renamed to use BIP-0347

    @EthanHeilman
    EthanHeilman committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6c729c4 View commit details
    Browse the repository at this point in the history

  2. Fixes comment URI

    @EthanHeilman
    EthanHeilman committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0a3869d View commit details
    Browse the repository at this point in the history

  3. Better quantum resistant section based Tim's comments 

    Adds additional acks
    @EthanHeilman
    EthanHeilman committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7ed8f6f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Specifies exact tree signature limit (suggested by Ali Sherief)

    @EthanHeilman
    EthanHeilman committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    852502b View commit details
    Browse the repository at this point in the history

  2. Adds comma 

    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c10870a View commit details
    Browse the repository at this point in the history

  3. Consistent formatting for Section Headings 

    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5413e18 View commit details
    Browse the repository at this point in the history

  4. Consistent formatting for Section Headings 

    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    dbc612e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Changes title of BIP to "Enable OP_CAT in Tapscript"

    @EthanHeilman
    EthanHeilman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a05543c View commit details
    Browse the repository at this point in the history

  2. OP_CAT in Tapscript 

    Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
    @EthanHeilman @vostrnad
    EthanHeilman and vostrnad committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1d55304 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Fixes typos 

    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3d78cc0 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Adds post history, fixes created date

    @EthanHeilman
    EthanHeilman committed May 1, 2024
    Configuration menu
    Copy the full SHA
    696cc17 View commit details
    Browse the repository at this point in the history

  2. Adds sentence suggested by murchandamus to quantum paragraph 

    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d670035 View commit details
    Browse the repository at this point in the history

  3. Increases commas and capital letters 

    This improves readability, thanks!

Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e9e7636 View commit details
    Browse the repository at this point in the history

  4. Adds commas 

    Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
    @EthanHeilman @murchandamus
    EthanHeilman and murchandamus committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6815c39 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Fixes link to liar liar

    @EthanHeilman
    EthanHeilman committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6ea9fda View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Add BIP-347 OP_CAT to table

    @murchandamus
    murchandamus committed May 3, 2024
    Configuration menu
    Copy the full SHA
    31f5192 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into cat

    @murchandamus
    murchandamus committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f05e162 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Improved accuracy of paragraph on OP_CAT's removal in 2010

    @EthanHeilman
    EthanHeilman committed May 5, 2024
    Configuration menu
    Copy the full SHA
    cda34ee View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Adds stable URL for Liar, Liar, Coins on Fire!

    @EthanHeilman
    EthanHeilman committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7ad0f82 View commit details
    Browse the repository at this point in the history