-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP 347: OP_CAT in Tapscript #1525
Merged
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
83ca57f
Create bip-???-cat.mediawiki
EthanHeilman f1169dd
Fixes typo
EthanHeilman 26e8e5f
Better fits bitcoin style guide
EthanHeilman 0335c9d
Grammar fix
EthanHeilman 3d31e5c
Adds brackets
EthanHeilman bb725e6
Wording
EthanHeilman 9779dc9
Keeps past tense consistant
EthanHeilman c5d66d6
Better phrasing
EthanHeilman 848352f
Phrasing
EthanHeilman a2b0100
Typo
EthanHeilman 6a790ec
Removes space in ref
EthanHeilman 01db3ac
Removes space in ref
EthanHeilman 945e2a3
Typos
EthanHeilman 7180c1c
Prefer bytes to Bytes
EthanHeilman 6f5a74d
Increases conciseness and clarity
EthanHeilman d4f85b1
Lowercase bytes
EthanHeilman beb5802
Adds subsection header
EthanHeilman 0a143d3
Use BSD-3 license
EthanHeilman 8219830
Code formatting
EthanHeilman 0b8a7e4
Code formatting
EthanHeilman 77509f6
Period to colon
EthanHeilman 4f39e4b
Avoids designing or discussing how to add post-quantum commitments to…
EthanHeilman 97635f5
Lowercase the signatures
EthanHeilman e3dc3ba
Italicize variables
EthanHeilman e492a90
Better reference for OP_CAT removal
EthanHeilman 785b11e
Add backwards compatibility section
0xBEEFCAF3 e91621e
Merge pull request #1 from 0xBEEFCAF3/patch-1
EthanHeilman 82fe9fc
specify the hex value of the opcode
EthanHeilman ae68ef1
add clarifying note about the current opcode
0xBEEFCAF3 f9e100e
Notes that the opcode used is the same as the original cat opcode
EthanHeilman 799dc0c
Merge branch 'cat' into patch-1
0xBEEFCAF3 2cec73a
rm comment on disabled CAT opcode
0xBEEFCAF3 5dde7ea
revert changes to abstract
0xBEEFCAF3 2b5ab3b
Merge pull request #2 from 0xBEEFCAF3/patch-1
EthanHeilman b349374
update OP_CAT implementation
0xBEEFCAF3 35641a8
Merge pull request #3 from 0xBEEFCAF3/cat
EthanHeilman ac231a1
Fixes broken mediawiki link
EthanHeilman c235aa4
Adds more acknowledgements
EthanHeilman f8ad6ed
Changes OP_CAT BIP based on feedback given by Bob Summerwill
EthanHeilman 6c729c4
Renamed to use BIP-0347
EthanHeilman 0a3869d
Fixes comment URI
EthanHeilman 7ed8f6f
Better quantum resistant section based Tim's comments
EthanHeilman 852502b
Specifies exact tree signature limit (suggested by Ali Sherief)
EthanHeilman c10870a
Adds comma
EthanHeilman 5413e18
Consistent formatting for Section Headings
EthanHeilman dbc612e
Consistent formatting for Section Headings
EthanHeilman a05543c
Changes title of BIP to "Enable OP_CAT in Tapscript"
EthanHeilman 1d55304
OP_CAT in Tapscript
EthanHeilman 3d78cc0
Fixes typos
EthanHeilman 696cc17
Adds post history, fixes created date
EthanHeilman d670035
Adds sentence suggested by murchandamus to quantum paragraph
EthanHeilman e9e7636
Increases commas and capital letters
EthanHeilman 6815c39
Adds commas
EthanHeilman 6ea9fda
Fixes link to liar liar
EthanHeilman 31f5192
Add BIP-347 OP_CAT to table
murchandamus f05e162
Merge branch 'master' into cat
murchandamus cda34ee
Improved accuracy of paragraph on OP_CAT's removal in 2010
EthanHeilman 7ad0f82
Adds stable URL for Liar, Liar, Coins on Fire!
EthanHeilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Typo
Co-authored-by: kallewoof <kalle.alm@gmail.com>
- Loading branch information
commit a2b0100671f492628ce219d706fa71a506ca0475
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lamport signatures in tapscript aren't actually quantum secure because the taptweak still relies on EC operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know it is an open question if the taptweak based commitment is quantum secure or not. This BIP could not take a position on this question. I will reword this to fix any confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I spoke too soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you brought this up. I wouldn't want the BIP to be seen as making an authoritative statement on this question. Let me know if you think my change addresses the issue or not.