Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade pebble and improve config #1979

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

flywukong
Copy link
Contributor

@flywukong flywukong commented Nov 10, 2023

Description

  1. upgrade pebble and improve config to enhance pebble as the bankup of leveldb
  2. improve config of pebble: increased BlockSizes so that the fixed cost of a block cache miss is reduced and use larger target file sizes which is same as CockroachDB . The config change is good for read caching performance.

Rationale

the block chasing performance of the geth with pebble (after upgrade) is not bad than leveldb, so it is suitable as an alternative to leveldb
image
the yellow one is leveldb , pebble avg: 371ms (avg value of 24 hours), leveldb avg: 380ms (avg value of 24 hours)

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@flywukong flywukong force-pushed the fix-upgrade-pebble branch 2 times, most recently from 8e44eb4 to a49b2fe Compare November 10, 2023 09:10
RenRick
RenRick previously approved these changes Nov 10, 2023
sysvm
sysvm previously approved these changes Nov 13, 2023
Copy link
Contributor

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flywukong flywukong dismissed stale reviews from sysvm and RenRick via ea99ea4 November 20, 2023 04:04
@brilliant-lx brilliant-lx merged commit 497fdf8 into bnb-chain:develop Nov 20, 2023
5 checks passed
joeylichang pushed a commit to joeylichang/bsc that referenced this pull request Dec 1, 2023
joeylichang pushed a commit to joeylichang/bsc that referenced this pull request Dec 1, 2023
fynnss pushed a commit to fynnss/bsc that referenced this pull request Dec 4, 2023
weiihann pushed a commit to weiihann/bsc that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants