feat: sync pebble db from bsc #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-2012
changed the title
| l.FilterType = pebble.TableFilter | ||
| if i > 0 { | ||
| l.TargetFileSize = opt.Levels[i-1].TargetFileSize * 2 | ||
| } |
There was a problem hiding this comment.
it it expected to be anelse branch here? to initial TargetFilesSize of levels[0] ?
if i > 0 {
l.TargetFileSize = opt.Levels[i-1].TargetFileSize * 2
} else {
l.TargetFileSize = xxx
}There was a problem hiding this comment.
If TargetFileSize == 0, will be set default TargetFileSize = 2MB in EnsureDefaults func~
bendanzhentan
approved these changes
Jan 23, 2024
owen-reorg
approved these changes
Jan 29, 2024
andyzhang2023
pushed a commit
to andyzhang2023/op-geth
that referenced
this pull request
Mar 4, 2024
Co-authored-by: wayen <2229306838@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick pebble-related pr from bsc.
bnb-chain/bsc#1979
bnb-chain/bsc#2072
bnb-chain/bsc#2120
Rationale
N/A.
Example
N/A.
Changes
Notable changes: