Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to workspace lints #3334

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Migrate to workspace lints #3334

merged 2 commits into from
Nov 17, 2023

Conversation

jedel1043
Copy link
Member

This PR migrates our lints to the newly released [lints] section, which also makes cargo clippy -- -D warnings work again.

@jedel1043 jedel1043 changed the base branch from main to ci-improvements October 2, 2023 00:56
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,524 76,524 0
Ignored 18,132 18,132 0
Failed 953 953 0
Panics 0 0 0
Conformance 80.04% 80.04% 0.00%

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (af1a918) 44.62% compared to head (744dda8) 44.60%.

Files Patch % Lines
boa_engine/src/builtins/options.rs 0.00% 21 Missing ⚠️
boa_examples/src/bin/futures.rs 0.00% 10 Missing ⚠️
boa_cli/src/main.rs 0.00% 1 Missing ⚠️
...oa_engine/src/builtins/temporal/duration/record.rs 0.00% 1 Missing ⚠️
boa_examples/src/bin/classes.rs 0.00% 1 Missing ⚠️
boa_examples/src/bin/closures.rs 0.00% 1 Missing ⚠️
boa_examples/src/bin/commuter_visitor.rs 0.00% 1 Missing ⚠️
boa_examples/src/bin/jsarraybuffer.rs 0.00% 1 Missing ⚠️
boa_examples/src/bin/jsdate.rs 0.00% 1 Missing ⚠️
boa_examples/src/bin/modules.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   44.62%   44.60%   -0.02%     
==========================================
  Files         487      487              
  Lines       50539    50537       -2     
==========================================
- Hits        22552    22541      -11     
- Misses      27987    27996       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

boa_gc/Cargo.toml Outdated Show resolved Hide resolved
Base automatically changed from ci-improvements to main October 3, 2023 00:56
@jedel1043 jedel1043 force-pushed the workspace-lints branch 2 times, most recently from be6df72 to e7d8a3a Compare November 16, 2023 21:42
@jedel1043 jedel1043 changed the title [MERGE WHEN 1.74 RELEASES] Migrate to workspace lints Migrate to workspace lints Nov 16, 2023
@jedel1043 jedel1043 marked this pull request as ready for review November 16, 2023 21:42
@jedel1043 jedel1043 requested a review from a team November 16, 2023 21:58
@jedel1043 jedel1043 added enhancement New feature or request rust Pull requests that update Rust code labels Nov 16, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Nov 16, 2023
@HalidOdat HalidOdat added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 421ff70 Nov 17, 2023
14 checks passed
@jedel1043 jedel1043 deleted the workspace-lints branch November 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants