Bump ICU4X to 1.4 and finish Intl impls with new APIs #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
force-pushed
the
bump-icu-1.4
branch
from
2cacdac
to
d2bef18
Compare
jedel1043
force-pushed
the
bump-icu-1.4
branch
from
d2bef18
to
8bb1b32
Compare
jedel1043
added
enhancement
This was referenced Nov 17, 2023
Test262 conformance changes
Fixed tests (2): |
jedel1043
force-pushed
the
bump-icu-1.4
branch
from
8bb1b32
to
d034bc7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
==========================================
- Coverage 44.62% 44.59% -0.04%
==========================================
Files 487 487
Lines 50539 50601 +62
==========================================
+ Hits 22552 22563 +11
- Misses 27987 28038 +51 ☔ View full report in Codecov by Sentry. |
jedel1043
force-pushed
the
bump-icu-1.4
branch
from
d034bc7
to
f52270d
Compare
nekevss
approved these changes
Nov 17, 2023
| // 6. Let type be pluralRules.[[Type]]. | ||
| // 7. Return PluralRuleSelectRange(locale, type, xp.[[PluralCategory]], yp.[[PluralCategory]]). | ||
| Ok( | ||
| plural_category_to_js_string(plural_rules.native.resolve_range(x.category, y.category)) |
There was a problem hiding this comment.
thought: Would it be worth checking if PluralCategory could implement Display? Then this could just be something akin to Ok(JsString::from(<PluralCategoryInput>.to_string()).into()).
Definitely, not necessary for this PR, and maybe it's been decided against by icu4x, but the thought popped in my head when I was looking through it.
There was a problem hiding this comment.
We really need a JsDisplay trait...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3334, just because it removes some Intl related warnings.