Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a catch all for other categories not labelled #3703

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

jasonwilliams
Copy link
Member

Add a catch all for other categories not labelled

@jasonwilliams jasonwilliams requested a review from a team February 28, 2024 23:20
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment this looks good to me! :)

.github/release.yml Show resolved Hide resolved
@HalidOdat HalidOdat requested a review from a team February 28, 2024 23:23
Comment on lines 16 to 19
- Internal
- title: Memory Optimizations
labels:
- memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Internal
- title: Memory Optimizations
labels:
- memory
- Internal
- memory

Can't it be added into as a internal improvement, instead of separate section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I thought you meant you wanted it as a section, my bad

Copy link
Member

@HalidOdat HalidOdat Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 On second thought maybe we should just remove the memory label here, and add Internal where needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't hurt to add it to the internal improvements section, ill put it there for now and if we don't use it its not a big deal. We may want to categorise some things as memory in future

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (6ddc2b4) to head (adc2061).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
+ Coverage   47.24%   47.66%   +0.42%     
==========================================
  Files         476      454      -22     
  Lines       46892    44570    -2322     
==========================================
- Hits        22154    21245     -909     
+ Misses      24738    23325    -1413     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HalidOdat HalidOdat requested a review from a team February 28, 2024 23:33
@HalidOdat HalidOdat added this to the v0.18.0 milestone Feb 28, 2024
@jasonwilliams jasonwilliams added this pull request to the merge queue Feb 28, 2024
Merged via the queue into boa-dev:main with commit 24f39a9 Feb 29, 2024
14 checks passed
@jasonwilliams jasonwilliams deleted the addOtherCategory branch July 15, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants