Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a catch all for other categories not labelled #3703

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add a catch all for other categories not labelled #3703

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07ba9b3
Add a catch all for other categories not labelled
jasonwilliams Feb 28, 2024
0ca04c2
Adding memory label
jasonwilliams Feb 28, 2024
adc2061
update labels
jasonwilliams Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,9 @@ changelog:
- title: Internal Improvements
labels:
HalidOdat marked this conversation as resolved.
Show resolved Hide resolved
- Internal
- title: Memory Optimizations
labels:
- memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Internal
- title: Memory Optimizations
labels:
- memory
- Internal
- memory

Can't it be added into as a internal improvement, instead of separate section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I thought you meant you wanted it as a section, my bad

Copy link
Member

@HalidOdat HalidOdat Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 On second thought maybe we should just remove the memory label here, and add Internal where needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't hurt to add it to the internal improvements section, ill put it there for now and if we don't use it its not a big deal. We may want to categorise some things as memory in future

- title: Other Changes
labels:
- "*"
Loading