Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SharedArrayBuffer #1051

Closed
jumde opened this issue Sep 9, 2018 · 1 comment · Fixed by brave/brave-core#426
Closed

Disable SharedArrayBuffer #1051

jumde opened this issue Sep 9, 2018 · 1 comment · Fixed by brave/brave-core#426
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes sec-high security
Milestone
0.55.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Sep 9, 2018 •
edited
Loading

Details here: brave/browser-laptop#12570

STR:

  1. Go to https://xlab.tencent.com/special/spectre/spectre_check.html
  2. Click the button to check your browser. It should report as not vulnerable.
@jumde jumde mentioned this issue Sep 9, 2018
Merged
11 tasks
@jumde jumde added the QA/Yes label Sep 9, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 9, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Sep 20, 2018 •
edited by srirambv
Loading

Verification Pass with

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@brave brave deleted a comment from GeetaSarvadnya Sep 21, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
mkarolin added a commit to brave/brave-core that referenced this issue Mar 12, 2019
@mkarolin
Disabled WebAssemblyThreads feature.
754cbfd 
This change is due to failure of browser test
SharedArrayBufferDisabledTest.IsDisabled.

Needs security review.

In C73 this feature was disabled by default. In C74 it is enabled
by default on all platforms but Android. When enabled, this feature
also enables SharedArrayBuffer feature, which we have disabled due
to vulnerability to Spectre. See
brave/brave-browser#1051.

Chromium change:

commit f9cc6b912e601070728b449892097cec0d59cbfa
Author: Ben Smith <binji@chromium.org>
Date:   Wed Feb 27 02:09:43 2019 +0000

    [wasm] Enable wasm threads by default

    See intent to ship blink-dev thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU

    Bug: chromium:754910
mkarolin added a commit to brave/brave-core that referenced this issue Mar 15, 2019
@mkarolin
Disabled WebAssemblyThreads feature.
6d2fda6 
This change is due to failure of browser test
SharedArrayBufferDisabledTest.IsDisabled.

Needs security review.

In C73 this feature was disabled by default. In C74 it is enabled
by default on all platforms but Android. When enabled, this feature
also enables SharedArrayBuffer feature, which we have disabled due
to vulnerability to Spectre. See
brave/brave-browser#1051.

Chromium change:

commit f9cc6b912e601070728b449892097cec0d59cbfa
Author: Ben Smith <binji@chromium.org>
Date:   Wed Feb 27 02:09:43 2019 +0000

    [wasm] Enable wasm threads by default

    See intent to ship blink-dev thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU

    Bug: chromium:754910
mkarolin added a commit to brave/brave-core that referenced this issue Mar 18, 2019
@mkarolin
Disabled WebAssemblyThreads feature.
d10d8f4 
This change is due to failure of browser test
SharedArrayBufferDisabledTest.IsDisabled.

Needs security review.

In C73 this feature was disabled by default. In C74 it is enabled
by default on all platforms but Android. When enabled, this feature
also enables SharedArrayBuffer feature, which we have disabled due
to vulnerability to Spectre. See
brave/brave-browser#1051.

Chromium change:

commit f9cc6b912e601070728b449892097cec0d59cbfa
Author: Ben Smith <binji@chromium.org>
Date:   Wed Feb 27 02:09:43 2019 +0000

    [wasm] Enable wasm threads by default

    See intent to ship blink-dev thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU

    Bug: chromium:754910
mkarolin added a commit to brave/brave-core that referenced this issue Mar 19, 2019
@mkarolin
Removed disabling of SharedArrayBuffer feature.
5a3fa98 
This feature was disabled by brave/brave-browser#1051 to mitigate
Spectre. Spectre was later addressed by Chromium via site isolation and
Chromium re-enabled SharedArrayBuffer, but Brave didn't. Now in C74,
WebAssemblyThreads feature is being enabled by default. Since
WebAssemblyThreads is built with and auto-enables SharedArrayBuffer,
there is no reason for us to continue keeping SharedArrayBuffer
disabled.

Aslo, removed a browser test for checking that SharedArrayBuffer is
disabled.

Chromium change making WebAssemblyThreads enabled by default:

commit f9cc6b912e601070728b449892097cec0d59cbfa
Author: Ben Smith <binji@chromium.org>
Date:   Wed Feb 27 02:09:43 2019 +0000

    [wasm] Enable wasm threads by default

    See intent to ship blink-dev thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU

    Bug: chromium:754910
mkarolin added a commit to brave/brave-core that referenced this issue Mar 20, 2019
@mkarolin
Removed disabling of SharedArrayBuffer feature.
32a8a24 
This feature was disabled by brave/brave-browser#1051 to mitigate
Spectre. Spectre was later addressed by Chromium via site isolation and
Chromium re-enabled SharedArrayBuffer, but Brave didn't. Now in C74,
WebAssemblyThreads feature is being enabled by default. Since
WebAssemblyThreads is built with and auto-enables SharedArrayBuffer,
there is no reason for us to continue keeping SharedArrayBuffer
disabled.

Aslo, removed a browser test for checking that SharedArrayBuffer is
disabled.

Chromium change making WebAssemblyThreads enabled by default:

commit f9cc6b912e601070728b449892097cec0d59cbfa
Author: Ben Smith <binji@chromium.org>
Date:   Wed Feb 27 02:09:43 2019 +0000

    [wasm] Enable wasm threads by default

    See intent to ship blink-dev thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU

    Bug: chromium:754910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes sec-high security
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Disabling SharedArrayBuffer brave/brave-core
5 participants
@bbondy @jumde @srirambv @LaurenWags @GeetaSarvadnya