Skip to content

Commit

Permalink
Disabled WebAssemblyThreads feature.
Browse files Browse the repository at this point in the history
This change is due to failure of browser test
SharedArrayBufferDisabledTest.IsDisabled.

Needs security review.

In C73 this feature was disabled by default. In C74 it is enabled
by default on all platforms but Android. When enabled, this feature
also enables SharedArrayBuffer feature, which we have disabled due
to vulnerability to Spectre. See
brave/brave-browser#1051.

Chromium change:

commit f9cc6b912e601070728b449892097cec0d59cbfa
Author: Ben Smith <binji@chromium.org>
Date:   Wed Feb 27 02:09:43 2019 +0000

    [wasm] Enable wasm threads by default

    See intent to ship blink-dev thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU

    Bug: chromium:754910
  • Loading branch information
mkarolin committed Mar 12, 2019
1 parent 3734b0d commit 754cbfd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
features::kAudioServiceOutOfProcess.name,
features::kDefaultEnableOopRasterization.name,
features::kSharedArrayBuffer.name,
features::kWebAssemblyThreads.name,
unified_consent::kUnifiedConsent.name,
};

Expand Down

0 comments on commit 754cbfd

Please sign in to comment.