Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all non-locale string instances of innerHTML #11686

Closed
diracdeltas opened this issue Sep 12, 2020 · 4 comments · Fixed by brave/brave-core#6646
Closed

remove all non-locale string instances of innerHTML #11686

diracdeltas opened this issue Sep 12, 2020 · 4 comments · Fixed by brave/brave-core#6646

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Sep 12, 2020

We will need this in order to be able to enabled trusted types by default. (See #11642, which covers the usages in locale strings.)

Regression tests for QA

  1. Go to brave://settings, make sure that all settings pages load correctly without any UI regressions. Change at least one setting and verify that the setting is actually changed.
  2. Go to brave://settings/help and make sure that clicking on the version opens a new tab to brave.com/latest.
  3. Make sure brave://settings/importData loads correctly and that you're able to import the specified types of data from at least one other browser. Make sure that unchecking a dialog item doesn't import that type of data.
  4. Check that github, reddit, and twitter inline tipping work correctly.
  5. [Beta/Stable builds only] Make sure that going to brave://flags shows a link to download the beta or nightly versions of Brave.
  6. Go to chrome web store, click on an extension, make sure it says Add to Brave instead of Add to Chrome.
@diracdeltas diracdeltas added security QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 12, 2020
@diracdeltas diracdeltas self-assigned this Sep 12, 2020
diracdeltas added a commit to diracdeltas/brave-core that referenced this issue Sep 14, 2020
and add npm script to check for Trusted Type violations. locale strings
will be fixed in a separate PR.

fix brave/brave-browser#11686
@diracdeltas diracdeltas added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 14, 2020
diracdeltas added a commit to brave/brave-core that referenced this issue Sep 16, 2020
and add npm script to check for Trusted Type violations. locale strings
will be fixed in a separate PR.

fix brave/brave-browser#11686
@diracdeltas diracdeltas added this to the 1.16.x - Nightly milestone Sep 17, 2020
deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
and add npm script to check for Trusted Type violations. locale strings
will be fixed in a separate PR.

fix brave/brave-browser#11686
@LaurenWags
Copy link
Member

LaurenWags commented Oct 9, 2020

Marking as QA/Blocked since test plan requires Stable build for part of the test plan. Once we get a release channel build for 1.16.x we can finish checking this one.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 12, 2020

Verification completed using:

Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (x86_64)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from description.

  • Visited brave://settings/ and confirmed each section loaded correctly. Where sections opened new pages, opened these pages and confirmed they displayed as expected. Changed various settings and confirmed they were changed. Close/relaunch and confirmed settings changes were retained on browser restart.
  • Visited brave://settings/help and clicked on the version. Confirmed a new tab opened and navigated to brave.com/latest.
  • Visited brave://settings/importData and confirmed the dialog loaded as expected. Confirmed able to import all checked items from Chrome. Used a clean profile and confirmed if some items are unchecked on brave://settings/importData, then they are not imported from Chrome.
  • Checked that when in-line tipping is enabled for Twitter, Reddit, GH I was able to use the in-line tip button to tip verified creators. Confirmed disabling in-line tipping for these platforms removed the in-line tip button as expected.
  • Visited Chrome webstore. Clicked on an extension and confirmed the button on the extension's page says 'Add to Brave'. Confirmed after adding the extension, the button changes to 'Remove from Brave'.
  • Visited brave://flags using Dev channel version above, confirmed no link to download Nightly.
Brave | 1.16.56 Chromium: 86.0.4240.75 (Official Build) beta (x86_64)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Visited brave://flags using Beta channel version above, confirmed link to download Nightly is displayed as expected. Confirmed it links to https://brave.com/download-nightly/ as expected.
Brave | 1.16.67 Chromium: 86.0.4240.111 (Official Build) (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Visited brave://flags using Release/Stable channel version above, confirmed link to download Beta is displayed as expected. Confirmed it links to https://brave.com/download-beta/ as expected.

Screen Shot 2020-10-22 at 7 44 20 AM


Verification passed on


Brave | 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

Verified test plan from the description.

  • Visited brave://settings/ and confirmed each section loaded correctly. Where sections opened new pages, opened these pages and confirmed they displayed as expected. Changed various settings and confirmed they were changed. Close/relaunch and confirmed settings changes were retained on the browser restart.
  • Visited brave://settings/help and clicked on the version. Confirmed a new tab opened and navigated to brave.com/latest.
  • Visited brave://settings/importData and confirmed the dialog loaded as expected. Confirmed able to import all checked items from Chrome. Used a clean profile and confirmed if some items are unchecked on brave://settings/importData, then they are not imported from Chrome.
  • Checked that when in-line tipping is enabled for Twitter, Reddit, GH I was able to use the in-line tip button to tip verified creators. Confirmed disabling in-line tipping for these platforms removed the in-line tip button as expected.
    Encountered GH inline Tip button is broken on few GH pages #11766
  • Visited Chrome webstore. Clicked on an extension and confirmed the button on the extension's page says 'Add to Brave'. Confirmed after adding the extension, the button changes to 'Remove from Brave'.
  • Visited brave://flags using Release/Stable channel version above, confirmed link to download Beta is displayed as expected. Confirmed it links to https://brave.com/download-beta/ as expected.
    image

Verification passed on

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Ubuntu 18.04 LTS

Verified test plan from description.

  • Visited brave://settings/ and confirmed each section loaded correctly. Where sections opened new pages, opened these pages and confirmed they displayed as expected. Changed various settings and confirmed they were changed. Close/relaunch and confirmed settings changes were retained on browser restart.
  • Visited brave://settings/help and clicked on the version. Confirmed a new tab opened and navigated to brave.com/latest.
  • Visited brave://settings/importData and confirmed the dialog loaded as expected. Confirmed able to import all checked items from Chrome. Used a clean profile and confirmed if some items are unchecked on brave://settings/importData, then they are not imported from Chrome.
  • Checked that when in-line tipping is enabled for Twitter, Reddit, GH I was able to use the in-line tip button to tip verified creators. Confirmed disabling in-line tipping for these platforms removed the in-line tip button as expected.
  • Visited Chrome webstore. Encountered [Desktop] Add to Brave is not replaced in non-EN locales #10570
  • There are no links on brave://flags on Linux, which is expected.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Oct 19, 2020
@srirambv
Copy link
Contributor

Removed OS/Android label after discussing with @NejcZdovc

@LaurenWags
Copy link
Member

Removing QA/Blocked as https://github.com/brave/brave-browser/releases/tag/v1.16.67 is available now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment