Remove non-locale uses of innerHTML and add CI script #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
diracdeltas
added
CI/skip-android
|
@NejcZdovc the builds all failed on the init step, so i assume probably not related, but i've just restarted them |
and add npm script to check for Trusted Type violations. locale strings will be fixed in a separate PR. fix brave/brave-browser#11686
diracdeltas
force-pushed
the
fix/innerHTML
branch
from
52edf9e
to
8d8b4f1
Compare
|
@NejcZdovc @petemill CI is looking good (can skip on android and iOS, i think). please take a look. |
NejcZdovc
approved these changes
Sep 17, 2020
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11686
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
The only new feature that this adds is a CI check for instances of
innerHTML(not counting the ones set in localization). To check that, runnpm run check_security.This PR has a high risk of UI regressions, so QA should check for this. See brave/brave-browser#11686 for QA test steps.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.