Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically update settings page to add local node option when a local node is installed #13171

Closed
bbondy opened this issue Dec 11, 2020 · 4 comments · Fixed by brave/brave-core#8315

Comments

@bbondy
Copy link
Member

bbondy commented Dec 11, 2020

This issue was broken out from @jessicaschilling's issue posted here: #13125

If you load brave://settings/extensions in a tab and then install the the IPFS local node in another tab. If you don't reload the settings page, then it shows a customized drop down list option.

After user is asked and chooses to "Enable IPFS", then the droplist includes a new item named "Customised".

Instead we should dynamically add a Local option and not wait for the page to be reloaded to show the proper value.

We'll instead always have a Local node option. When a user selects Local node, if it is not installed, we'll open a tab with this URI:
ipfs://bafkreigxbf77se2an2u6hmg2kxxbhmenetc7dzvkd3rl4m2orlobjvqcqq

@bbondy bbondy added priority/P5 Not scheduled. Don't anticipate work on this any time soon. OS/Desktop labels Dec 11, 2020
@lidel
Copy link

lidel commented Dec 17, 2020

I'd argue "Local (embedded go-ipfs)" should ALWAYS be on the list, and when user selects it, Brave should always make a check if go-ipfs is installed, if not, install it and start it.

Alternative is to have a separate "Install and run IPFS node" button above the "Method to resolve IPFS resources" that is hidden after install.

Without either of those, we have onboarding problem, because we assume user will enter ipfs://cid to trigger the install, while I'd argue its more likely that:

  1. User learns Brave "supports IPFS natively"
  2. User goes to Settings and does not see option to start embedded node, the only option is a third-party gateway:

    2020-12-17--15-28-25

@jessicaschilling
Copy link

Completely agree.

@bbondy
Copy link
Member Author

bbondy commented Dec 17, 2020

That sounds good as an alternate way to install rather than when they visit an ipfs:// URL.
We'll have to take this into account as part of the next set of work in the new year though.

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Dec 17, 2020
@bbondy bbondy self-assigned this Jan 13, 2021
@bbondy bbondy removed their assignment Feb 7, 2021
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 23, 2021
@stephendonner
Copy link

Verified PASSED using nightly build with the testplan from brave/brave-core#8315

Brave 1.24.26 Chromium: 90.0.4430.30 (Official Build) nightly (x86_64)
Revision 5674335ff855e43f3bccf8cfc29a779bdf0d067f-refs/branch-heads/4430@{#532}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. new profile
  2. launched Brave
  3. loaded brave://ipfs-internals to confirm IPFS local node was neither running nor installed
  4. opened a new tab with brave://settings/ipfs
  5. fromMethod to resolve IPFS resources, chose Local node
  6. switched back over to brave://ipfs-internals tab and confirmed the installation and local-node initialization began and completed
  7. loaded ipns://brantly.eth in a new tab and confirmed it loaded it over localhost (via Developer Tools' Network panel): brantly.eth.ipns.localhost

Screen Shot 2021-03-25 at 4 28 11 PM

ipfs-local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants