Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local node to list #8315

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Add local node to list #8315

merged 1 commit into from
Mar 23, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 22, 2021

Resolves brave/brave-browser#13171

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Remove user data folder
  • Start browser and check ipfs method in settings
  • Local node should be in the list
  • Select local node method, the node should be installed automatically

@spylogsster spylogsster requested a review from bbondy March 22, 2021 14:49
@spylogsster spylogsster self-assigned this Mar 22, 2021
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but since we don't give a privacy disclosure warning let's add text like this:

This protocol has different privacy considerations from HTTP(S). Learn more

Where learn more is a link to the same as the interstitial page.

@spylogsster spylogsster force-pushed the update-settings-items branch 2 times, most recently from a8a9d30 to 91c4086 Compare March 23, 2021 11:53
@spylogsster spylogsster requested a review from a team as a code owner March 23, 2021 11:53
@spylogsster
Copy link
Contributor Author

spylogsster commented Mar 23, 2021

This looks good but since we don't give a privacy disclosure warning let's add text like this:

This protocol has different privacy considerations from HTTP(S). Learn more

Where learn more is a link to the same as the interstitial page.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically update settings page to add local node option when a local node is installed
2 participants