Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error/warning pages #532

Closed
jumde opened this issue Jul 12, 2018 · 5 comments
Closed

Update error/warning pages #532

jumde opened this issue Jul 12, 2018 · 5 comments
Labels
closed/invalid closed/not-actionable

Comments

@jumde
Copy link
Contributor

jumde commented Jul 12, 2018

@bbondy bbondy added this to the Backlog milestone Jul 16, 2018
@jumde jumde mentioned this issue Aug 20, 2018
Closed
4 tasks
@rebron
Copy link
Collaborator

rebron commented Aug 20, 2018

What are we updating on these pages, design and/or the links Learn More going to community.brave.com instead of Google Chrome Help?

@jumde
Copy link
Contributor Author

jumde commented Aug 21, 2018

At a minimum, we need to update the links to point to brave domains.

cc: @bradleyrichter: should we update the design for these warning pages as well?

@tildelowengrimm tildelowengrimm added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. security sec-low labels Sep 15, 2018
@rossmoody
Copy link
Contributor

Closing this one in favor of #1149.

@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 17, 2018
@bbondy
Copy link
Member

bbondy commented Oct 17, 2018

Btw pls reset milestone to the Dupe / Invalid / Not actionable one when closing without a code change. Thanks! (I did the ones up until now)

@rossmoody
Copy link
Contributor

@bbondy Got it. Thank you for fixing for me.

@rossmoody rossmoody removed design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Oct 17, 2018
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
This was referenced Mar 25, 2021
Closed
Closed
This was referenced Mar 25, 2021
Closed
Closed
Closed
@stephendonner stephendonner mentioned this issue Mar 25, 2021
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid closed/not-actionable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tildelowengrimm @bbondy @jumde @kjozwiak @rebron @NejcZdovc @rossmoody