CR90 - Currency and User placeholders are empty in Tipping banner

[GeetaSarvadnya]

Description

Currency and User placeholders are empty in Tipping banner

Steps to Reproduce

1. Open Brave 1.24.26
2. Enable rewards (Don't claim UGP grants)
3. Open https://vimeo.com/bravelaurenwags or any other publisher
4. Open the tipping banner
5. Click on the Send a tip button
6. Not enough [[currency]] message is shown
7. Open https://twitter.com/bravelaurenwags in a new tab
8. Click on the inline tip for any of the tweets on twitter
9. [User] place holder is empty in tipping banner

Actual result:

[Currency] place holder is empty

[User] place holder is empty in tipping banner

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.24.26 Chromium: 90.0.4430.30 (Official Build) nightly (64-bit)
Revision	5674335ff855e43f3bccf8cfc29a779bdf0d067f-refs/branch-heads/4430@{#532}
OS	Windows 10 OS Version 2004 (Build 19041.867)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @zenparsing @emerick

[GeetaSarvadnya]

@zenparsing Just curious to know if this issue arising due to CR90?

[zenparsing]

@GeetaSarvadnya That's correct - the message patterns were updated in CR90, but we missed one place where we are still expecting the old patterns.

[stephendonner]

Verified PASSED using nightly build with the inline testplan here, on

Brave	1.24.32 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision	e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

1. Opened Brave 1.24.32
2. Enabled rewards (Didn't claim UGP grants)
3. Opened https://vimeo.com/bravelaurenwags
4. Opened the tipping banner
5. Clicked on the Send a tip button
6. Not enough [[currency]] message is shown

Verified this is now fixed

7. Opened https://twitter.com/bravelaurenwags in a new tab
8. Clicked on the inline tip for any of the tweets on twitter
9. [User] place holder is empty in tipping banner

Verified this is now fixed