Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 89 to Chromium 90 (1.23.x). #8440

Merged
merged 8 commits into from
Apr 7, 2021
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Apr 6, 2021

Fixes brave/brave-browser#14037
Fixes brave/brave-browser#14920
Fixes brave/brave-browser#14931
Fixes brave/brave-browser#15008
Fixes brave/brave-browser#15052
Fixes brave/brave-browser#14973

Related PR: #15136

Uplift from #7866
Uplift from #8341
Uplift from #8354
Uplift from #8385
Uplift from #8405
Uplift from #8368

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

mkarolin and others added 4 commits April 5, 2021 21:23
Upgrade from Chromium 89 to Chromium 90.
Fixes redirect-cc.exe build for VS2019.
Upgrade from Chromium 90.0.4430.30 to Chromium 90.0.4430.41.
Upgrade patches from Chromium 90.0.4430.41 to Chromium 90.0.4430.51
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Apr 6, 2021
@mkarolin mkarolin requested a review from a team April 6, 2021 02:24
@mkarolin mkarolin self-assigned this Apr 6, 2021
@mkarolin mkarolin requested a review from a team as a code owner April 6, 2021 02:24
@kjozwiak
Copy link
Member

kjozwiak commented Apr 6, 2021

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-cr90-1.23.x-linux/5/execution/node/254/log/ & https://ci.brave.com/job/pr-brave-browser-cr90-1.23.x-linux/5/execution/node/257/log/. However, these are known failures and unrelated to this specific PR. Regarding, BraveClearDataOnExitTwoBrowsersTest.OneGuestExitsLast, I think we should be fine as it passed on Windows.

15:43:00  1 test timed out:
15:43:00      BraveClearDataOnExitTwoBrowsersTest.OneGuestExitsLast (../../brave/browser/browsing_data/brave_clear_browsing_data_browsertest.cc:366)
15:43:00  5 tests crashed:
15:43:00      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
15:43:00      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
15:43:00      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
15:43:00      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
15:43:00      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

Restarting macOS due to dist failing as per https://ci.brave.com/job/pr-brave-browser-cr90-1.23.x-macos/5/execution/node/276/log/.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2021

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-cr90-1.23.x-macos/7/execution/node/255/log/ & https://ci.brave.com/job/pr-brave-browser-cr90-1.23.x-macos/7/execution/node/258/log/. However, these failures are known and unrelated to this specific PR.

23:10:05  5 tests crashed:
23:10:05      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
23:10:05      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
23:10:05      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
23:10:05      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
23:10:05      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 31ee173 into 1.23.x Apr 7, 2021
@kjozwiak kjozwiak deleted the cr90-1.23.x branch April 7, 2021 05:19
@kjozwiak kjozwiak added this to the 1.23.x - Beta milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants