Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint global settings are overwritten when a new Tor Window is launched #1641

Closed
srirambv opened this issue Oct 17, 2018 · 1 comment
Closed

Fingerprint global settings are overwritten when a new Tor Window is launched #1641

srirambv opened this issue Oct 17, 2018 · 1 comment
Labels
closed/invalid

Comments

@srirambv
Copy link
Contributor

Description

Fingerprint global settings are overwritten when a new Tor Window is launched

Steps to Reproduce

  1. Open Tor Window
  2. Go to settings, Change Fingerprint setting from default value and close Tor Windows
  3. Open a new Tor window and check settings, Fingerprint setting is changed to default value

Actual result:

Fingerprint global settings are overwritten when a new Tor Window is launched

Expected result:

Settings should be retained for all new Tor windows launched

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
  • Does it reproduce on browser-laptop?
    No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added feature/shields The overall Shields feature in Brave. feature/tor feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified labels Oct 17, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Oct 17, 2018
@srirambv srirambv mentioned this issue Oct 17, 2018
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Oct 18, 2018
Closed
@rebron rebron modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 19, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 19, 2018
@tildelowengrimm tildelowengrimm modified the milestones: 0.56.x - Beta, 1.x Backlog Oct 23, 2018
@tildelowengrimm tildelowengrimm removed the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 23, 2018
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label Oct 23, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Oct 30, 2018
@srirambv srirambv mentioned this issue Nov 6, 2018
Closed
@tildelowengrimm
Copy link
Contributor

Collapsing this suite of issues into the general task to reimplement Tor as session windows. #34

@tildelowengrimm tildelowengrimm modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 7, 2018
@kjozwiak kjozwiak added closed/invalid and removed QA/Test-Plan-Specified feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. feature/tor feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. priority/P4 Planned work. We expect to get to it "soon". labels Oct 7, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tildelowengrimm @bbondy @kjozwiak @rebron @srirambv @riastradh-brave @pilgrim-brave