Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie global settings are overwritten on startup #1592

Closed
bbondy opened this issue Oct 15, 2018 · 3 comments · Fixed by brave/brave-core#651
Closed

Cookie global settings are overwritten on startup #1592

bbondy opened this issue Oct 15, 2018 · 3 comments · Fixed by brave/brave-core#651
Assignees
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@bbondy
Copy link
Member

bbondy commented Oct 15, 2018

This was split into 2 by me, but credit @srirambv for the posting of the issue.

See also:
#1524

Description

While verifying #1364 found Cookies settings are not retained across session

Steps to Reproduce

  1. Clean profile on 0.55.12
  2. Change default shields settings to different value
  3. Restart browser, Cookie setting gets reset to default value
  4. Change default shield settings and visit a site in a new tab
  5. Restart browser, cookie setting still gets reset to default value

Actual result:

1364

Expected result:

All shields settings which are changed at global setting should be retained across session

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes on Beta. Need to test on new Dev
  • Does it reproduce on browser-laptop? No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 15, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 15, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Oct 16, 2018
@srirambv
Copy link
Contributor

@pilgrim-brave @bbondy Cookies and Fingerprint settings are not retained on startup for Tor windows. Any change only persists for that particular session. Closing and relaunching it will reset it back to default values. Logged #1641 for Fingerprint settings on Tor windows

@LaurenWags
Copy link
Member

Reproduced with

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

@bbondy bbondy modified the milestones: 1.x Backlog, FROZEN: 0.55.x - Release Oct 18, 2018
@bbondy bbondy added the QA/Yes label Oct 18, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 18, 2018

Verification Passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

Verified passed with

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

Verification passed on

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants