Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EAFF custom header #16961

Closed
fmarier opened this issue Jul 15, 2021 · 2 comments · Fixed by brave/brave-core#9442
Closed

Remove EAFF custom header #16961

fmarier opened this issue Jul 15, 2021 · 2 comments · Fixed by brave/brave-core#9442
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.29.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Jul 15, 2021

This header was tied to a custom homepage campaign that is no longer active.
@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 15, 2021
@fmarier fmarier self-assigned this Jul 15, 2021
@fmarier fmarier mentioned this issue Jul 15, 2021
Merged
24 tasks
fmarier added a commit to brave/brave-core that referenced this issue Jul 15, 2021
@fmarier
Remove EAFF custom header (fixes brave/brave-browser#16961)
95934b8
fmarier added a commit to brave/brave-core that referenced this issue Jul 15, 2021
@fmarier
Merge pull request #9442 from brave/remove-eaff-custom-header-16961
1ceafbe 
Remove EAFF custom header (fixes brave/brave-browser#16961)
@fmarier fmarier added this to the 1.29.x - Nightly milestone Jul 15, 2021
@stephendonner
Copy link

stephendonner commented Jul 16, 2021 •
edited by GeetaSarvadnya
Loading

Verified PASSED; followed the steps from brave/brave-core#9442 and confirmed the custom EAFF header is NOT present, in

Brave 1.29.5 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)
pre-fix (with X-Brave-Partner: eaff header post-fix (missing X-Brave-Partner: eaff header
125708823-d4fe23d3-5dac-49ab-a6ff-6577f93c0b43 Screen Shot 2021-07-16 at 11 17 08 AM

Verification passed on

Brave 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#9442. X-Brave-Partner: eaff header is not included

image

Verification passed on


Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.29.60 x64 Beta build

Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

Remove EAFF custom header (fixes brave/brave-browser#16961) brave/brave-core
6 participants
@fmarier @stephendonner @srirambv @LaurenWags @btlechowski @GeetaSarvadnya