Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EAFF custom header (fixes brave/brave-browser#16961) #9442

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jul 15, 2021

Resolves brave/brave-browser#16961

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Visit https://eaff.com/ with the Network tab of the devtools open.
  2. Click on the main request (the document).
  3. Look for the X-Brave-Partner header in the Request headers.
    Screenshot from 2021-07-14 17-13-59
  4. Confirm that the header is not present.

@fmarier fmarier force-pushed the remove-eaff-custom-header-16961 branch from cf046a8 to 95934b8 Compare July 15, 2021 01:04
@fmarier fmarier requested a review from kkuehlz July 15, 2021 01:05
Copy link
Contributor

@kkuehlz kkuehlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong
Copy link
Member

FYI, we set milestone label after merging - https://github.com/brave/brave-browser/wiki/Pull-requests-with-missing-milestones

@simonhong simonhong removed this from the 1.29.x - Nightly milestone Jul 15, 2021
@fmarier fmarier merged commit 1ceafbe into master Jul 15, 2021
@fmarier fmarier deleted the remove-eaff-custom-header-16961 branch July 15, 2021 14:22
@fmarier fmarier added this to the 1.29.x - Nightly milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EAFF custom header
4 participants