Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave_stats: Change dtoi parameter to 30 days #17089

Closed
kkuehlz opened this issue Jul 21, 2021 · 3 comments · Fixed by brave/brave-core#9522
Closed

brave_stats: Change dtoi parameter to 30 days #17089

kkuehlz opened this issue Jul 21, 2021 · 3 comments · Fixed by brave/brave-core#9522
Assignees
@kkuehlz
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.29.x - Release

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Jul 21, 2021

Growth team requested this so retention data can be better understood.
@kkuehlz kkuehlz self-assigned this Jul 21, 2021
@kkuehlz kkuehlz added the QA/Yes label Jul 21, 2021
@kkuehlz
Copy link
Contributor Author

kkuehlz commented Jul 21, 2021

Test Plan

Follow the same steps described in #10061, but use 30 days instead of 14 days.

@kkuehlz kkuehlz added OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include labels Jul 21, 2021
kkuehlz pushed a commit to brave/brave-core that referenced this issue Jul 21, 2021
brave_stats: Change dtoi expiration to 30 days
47e9195 
This was requested by the growth team and passed privacy review.

Resolves brave/brave-browser#17089
@kkuehlz kkuehlz mentioned this issue Jul 21, 2021
Merged
24 tasks
kkuehlz pushed a commit to brave/brave-core that referenced this issue Jul 22, 2021
brave_stats: Change dtoi expiration to 30 days
ed67533 
This was requested by the growth team and passed privacy review.

Resolves brave/brave-browser#17089
@kkuehlz kkuehlz added this to the 1.29.x - Nightly milestone Jul 23, 2021
@stephendonner
Copy link

stephendonner commented Jul 26, 2021 •
edited by GeetaSarvadnya
Loading

Verified PASSED using #10061 with 30 days as the variation, with build

Brave 1.29.27 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 11.5 (Build 20G71)

Steps:

  1. new profile
  2. launched Charles Proxy
  3. launched Brave
  4. examined the request to laptop-updates/1/usage/brave_core; confirmed the dtoi= parameter reads today's date, 2020-07-26
  5. moved system clock forward 30 days to confirm the dtoi= parameter is null
ping on initial install moved computer date 30 days ahead
Screen Shot 2021-07-26 at 11 24 15 AM Screen Shot 2021-08-27 at 11 25 42 AM

Verification passed on

Brave 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Ubuntu 18.04 LTS

Verified test plan from #10061

image

After 29 days
image

After 30 days dtoi= parameter is null
image

Verification passed on

Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)
ping on initial install moved computer date 30 days ahead
image image

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.29.70 x64 Beta build

Verification passed on Samsung Tab A with Android 10 running 1.29.70 x64 Beta build

image image

@LaurenWags LaurenWags mentioned this issue Aug 30, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Sep 2, 2021
Closed
@porteron porteron mentioned this issue Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkuehlz kkuehlz

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

brave_stats: Change dtoi expiration to 30 days brave/brave-core
6 participants
@stephendonner @srirambv @LaurenWags @kkuehlz @btlechowski @GeetaSarvadnya