Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global cookiesettings are overwritten when a new Tor Window is launched #1712

Closed
srirambv opened this issue Oct 18, 2018 · 2 comments
Closed

Comments

@srirambv
Copy link
Contributor

Description

Global cookiesettings are overwritten when a new Tor Window is launched

Steps to Reproduce

  1. Open Tor Window
  2. Go to settings, Change Cookie setting from default value and close Tor Windows
  3. Open a new Tor window and check settings, Cookie setting is changed to default value

Actual result:

Cookie settings are overwritten when a new Tor Window is launched

Expected result:

Cookie Settings should be retained for all new Tor windows launched

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
  • Does it reproduce on browser-laptop?
    No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@btlechowski
Copy link

Reproduced on Windows 7 x64

Brave 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

@rebron rebron modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 19, 2018
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 19, 2018
@tildelowengrimm tildelowengrimm modified the milestones: 0.56.x - Beta, 1.x Backlog Oct 23, 2018
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label Oct 23, 2018
@tildelowengrimm tildelowengrimm added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 30, 2018
@tildelowengrimm
Copy link
Contributor

Collapsing this suite of issues into the general task to reimplement Tor as session windows. #34

@tildelowengrimm tildelowengrimm modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 7, 2018
@kjozwiak kjozwiak added closed/invalid and removed QA/Test-Plan-Specified bug feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. feature/tor feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 7, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants