Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiring up BraveVPNService with BraveVPNOSConnectionAPI #17658

Closed
Tracked by #15804
simonhong opened this issue Aug 24, 2021 · 0 comments · Fixed by brave/brave-core#9836
Closed
Tracked by #15804

Wiring up BraveVPNService with BraveVPNOSConnectionAPI #17658

simonhong opened this issue Aug 24, 2021 · 0 comments · Fixed by brave/brave-core#9836
Assignees
@simonhong
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.30.x - Release

Comments

@simonhong
Copy link
Member

BraveVpnService will ask os vpn connection to BraveVPNOSConnectionAPI.
@simonhong simonhong self-assigned this Aug 24, 2021
@simonhong simonhong mentioned this issue Aug 24, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Aug 24, 2021
@simonhong
Wired up BraveVpnService with BraveVPNOSConnectionAPI
74435e2 
fix brave/brave-browser#17658

Two cmd switches are added.

Use "--brave-vpn-test-credentials=connection-name:host-name:user-name:password" to pass
testable credentials for connecting to guardian service.
This will be useful before we can get real credentials from payment service.

Use "--brave-vpn-simulation" to simulate os vpn connection instead of call os' vpn api.
This will be useful when it's difficult to call os'vpn api such as macOS.
@simonhong simonhong added this to the 1.30.x - Nightly milestone Aug 25, 2021
@bsclifton bsclifton mentioned this issue Aug 25, 2021
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

Wired up BraveVpnService with BraveVPNOSConnectionAPI brave/brave-core
1 participant
@simonhong