Wired up BraveVpnService with BraveVPNOSConnectionAPI #9836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/brave-browser#17658 Two cmd switches are added. Use "--brave-vpn-test-credentials=connection-name:host-name:user-name:password" to pass testable credentials for connecting to guardian service. This will be useful before we can get real credentials from payment service. Use "--brave-vpn-simulation" to simulate os vpn connection instead of call os' vpn api. This will be useful when it's difficult to call os'vpn api such as macOS.
nullhook
reviewed
Aug 24, 2021
components/brave_vpn/switches.h
Outdated
| // Value should be "connection-name:host-name:user-name:password". | ||
| constexpr char kBraveVPNTestCredentials[] = "brave-vpn-test-credentials"; | ||
| // Use for simulation instead of calling os platform apis. | ||
| constexpr char kBraveVPNSimulation[] = "brave-vpn-simulation"; |
There was a problem hiding this comment.
not sure if we're using "simulation" in other modules but i'd think grammatically this would be ideal:
--brave-vpn-simulate
Made BraveVpnService common on all platform and added desktop specific impls to BraveVpnServiceDesktop.
|
Set skipped because last change was just switch name string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#17658
Two cmd switches are added.
Use "--brave-vpn-test-credentials=connection-name:host-name:user-name:password" to pass
testable credentials for connecting to guardian service.
This will be useful before we can get real credentials from payment service.
Use "--brave-vpn-simulate" to simulate os vpn connection instead of call os' vpn api.
This will be useful when it's difficult to call os'vpn api such as macOS.
and Introduced
BraveVpnServiceDesktopinstead of adding desktop's impl toBraveVpnServicebecause android also uses
BraveVpnService.Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: