Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add do not ask again checkbox on crash report prompt #18103

Closed
rebron opened this issue Sep 14, 2021 · 4 comments · Fixed by brave/brave-core#10093
Closed

Add do not ask again checkbox on crash report prompt #18103

rebron opened this issue Sep 14, 2021 · 4 comments · Fixed by brave/brave-core#10093
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 14, 2021

Description

Add and support a do not ask again checkbox/setting for the crash report dialog.

No additional UI or setting for users to show the prompt again is needed; users can go to brave://settings/privacy to toggle sending crash reports.

Steps to Reproduce

  1. On clean profile/release channel, force crash and notice crash prompt setting on restart. brave://inducebrowsercrashforrealz/
  2. No Do not show again checkbox
  3. For testers, note that crash report prompt is on by default for beta and nightly.

Actual result:

131420802-4831bd06-2e63-4930-bef3-d04890e84b5c

Expected result:

image

Reproduces how often:

n/a

Brave version (brave://version info)

n/a

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? no, crash report prompt is on by default
  • Can you reproduce this issue with the nightly channel? no, crash report prompt is on by default

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron changed the title add do not ask again checkbox on crash report prompt Add do not ask again checkbox on crash report prompt Sep 14, 2021
@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Sep 14, 2021
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Sep 14, 2021
@User198263321
Copy link

You are able to reproduce this in non-stable branches if you manually opt-out out of sending crash reports

@stephendonner
Copy link

stephendonner commented Sep 16, 2021

Verified PASSED using

Brave 1.31.47 Chromium: 94.0.4606.50 (Official Build) nightly (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. clean profile
  2. launched Brave and disabled crash reporting from brave://settings/privacy and re-launched
  3. loaded brave://inducebrowsercrashforrealz/ and crashed
  4. re-launched and checked the crash-permission/ask dialog is launched
  5. checked Don't ask again checkbox and clicked Block
  6. shut down Brave
  7. re-launched to save preferences
  8. loaded brave://inducebrowsercrashforrealz/ again
  9. re-launched and check crash permission ask dialog is not launched
  10. confirmed that Help improve Brave's features and performance was disabled/off
example example example example
Screen Shot 2021-09-16 at 2 47 06 PM Screen Shot 2021-09-16 at 2 47 49 PM Screen Shot 2021-09-16 at 2 48 28 PM Screen Shot 2021-09-16 at 2 47 06 PM

Verified PASSED using

Brave 1.31.64 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Linux

Steps:

  1. clean profile
  2. launched Brave and disabled crash reporting from brave://settings/privacy and re-launched
  3. loaded brave://inducebrowsercrashforrealz/ and crashed
  4. re-launched and checked the crash-permission/ask dialog is launched
  5. checked Don't ask again checkbox and clicked Block
  6. shut down Brave
  7. re-launched to save preferences
  8. loaded brave://inducebrowsercrashforrealz/ again
  9. re-launched and check crash permission ask dialog is not launched
  10. confirmed that Help improve Brave's features and performance was disabled/off
example example example example
Screen Shot 2021-09-28 at 4 04 12 PM Screen Shot 2021-09-28 at 4 05 28 PM Screen Shot 2021-09-28 at 4 05 31 PM Screen Shot 2021-09-28 at 4 07 06 PM

Verification passed on

Brave | 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Steps:

  1. clean profile
  2. launched Brave and disabled crash reporting from brave://settings/privacy and re-launched
  3. loaded brave://inducebrowsercrashforrealz/ and crashed
  4. re-launched and checked the crash-permission/ask dialog is launched
  5. checked Don't ask again checkbox and clicked Block
  6. shut down Brave
  7. re-launched to save preferences
  8. loaded brave://inducebrowsercrashforrealz/ again
  9. re-launched and check crash permission ask dialog is not launched
  10. confirmed that Help improve Brave's features and performance was disabled/off
example example example example
image image image image

@rebron
Copy link
Collaborator Author

rebron commented Sep 20, 2021

@stephendonner Step 5 and Step 10 don't look right. Shouldn't step 10 be off if selecting block.
cc: @simonhong

@stephendonner
Copy link

@stephendonner Step 5 and Step 10 don't look right. Shouldn't step 10 be off if selecting block.
cc: @simonhong

Fixed; sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants