Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added don't ask checkbox to crash report permission ask dialog #10093

Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 15, 2021

fix brave/brave-browser#18103

User will not see this dialog anymore after checking this checkbox.

Screen Shot 2021-09-15 at 9 58 34 AM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_browser_tests -- --filter=BraveLocalStatePrefsBrowserTest.DefaultLocalStateTest

  1. Launch browser and disable crash report from settings and re-launch
  2. Load brave://inducebrowsercrashforrealz/
  3. Re-launch and check crash permission ask dialog is launched
  4. Check don't ask again checkbox and click Block
  5. Re-launch to save preferences
  6. Load brave://inducebrowsercrashforrealz/ again
  7. Re-launch and check crash permission ask dialog is not launched

@simonhong simonhong self-assigned this Sep 15, 2021
@simonhong simonhong force-pushed the add_dont_ask_checkbox_to_crash_report_permission_ask_dialog branch from 020fb73 to d37f2cc Compare September 15, 2021 02:51
@simonhong simonhong force-pushed the add_dont_ask_checkbox_to_crash_report_permission_ask_dialog branch from 36cccce to 25f4916 Compare September 15, 2021 12:20
Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bsclifton bsclifton merged commit 2fbc667 into master Sep 15, 2021
@bsclifton bsclifton deleted the add_dont_ask_checkbox_to_crash_report_permission_ask_dialog branch September 15, 2021 21:35
@bsclifton bsclifton added this to the 1.31.x - Nightly milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add do not ask again checkbox on crash report prompt
4 participants