Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SafeBrowsing #204

Closed
2 of 4 tasks
jumde opened this issue May 16, 2018 · 3 comments
Closed
2 of 4 tasks

Enable SafeBrowsing #204

jumde opened this issue May 16, 2018 · 3 comments

Comments

@jumde
Copy link
Contributor

jumde commented May 16, 2018

  • Replace kSbV4UrlPrefix with the brave proxy
  • Update the interstitial pages
  • Disable reporting
  • Update API key

Test Plan

  1. Open brave and navigate to https://brave.com
  2. Wait for 2-3 mins, and verify the *.store files have been created in <UserData>/Safe Browsing directory
  3. Navigate to https://testsafebrowsing.appspot.com/ and verify that you see appropriate warnings for different demo pages.
@bbondy
Copy link
Member

bbondy commented Jun 12, 2018

Is this issue fully completed?

@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@jumde
Copy link
Contributor Author

jumde commented Aug 20, 2018

API key update is tracked here: #543
Interstitial pages update is tracked here: #532

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Permissions Blacklisting does not work, but it also does not work in Chrome 69.0.3497.100

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Permission blocking works on Linux
    image

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants