Setting proxy for safe browsing requests #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
previously requested changes
May 20, 2018
jumde
force-pushed
the
safebrowsing_proxy
branch
3 times, most recently
from
fc34341
to
1dc00a9
Compare
bbondy
requested changes
May 22, 2018
bbondy
requested changes
May 22, 2018
jumde
force-pushed
the
safebrowsing_proxy
branch
2 times, most recently
from
f5be645
to
c4dffff
Compare
bridiver
reviewed
May 23, 2018
| @@ -1,7 +1,10 @@ | |||
| import("//build/config/features.gni") | |||
|
|
|||
| source_set("net") { | |||
| configs += [ "//brave/build/geolocation" ] | |||
| configs += [ | |||
| "//brave/build/geolocation", | |||
There was a problem hiding this comment.
I'm not sure that using configs like this is the best way to do this. I think it would be better to create a normal dependency //brave/browser/safe_browsing and give it a public config. That would be a more typical pattern.
There was a problem hiding this comment.
btw - my reasoning for this is that a dep provides more flexibility to manage configs, sources and add any additional deps that might be required in the future. In most cases (there are some exceptions), configs are treated more like internal implementation details for deps and those details are passed along using public_configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#204