Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: market data asset detail #12732

Closed

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Mar 24, 2022

Adds a view to display asset details when a user navigates from market view assets list

Resolves brave/brave-browser#20674

Note: This PR will only be merged after this PR #12635 is merged since this feature has a dependency on it.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • [] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Mar 24, 2022
@muliswilliam muliswilliam changed the title Feature/market data asset detail Feature: market data asset detail Mar 24, 2022
@muliswilliam muliswilliam changed the base branch from master to markets-ratios-proxy March 31, 2022 18:59
@muliswilliam muliswilliam changed the base branch from markets-ratios-proxy to feature/market-data-top-section March 31, 2022 19:21
@muliswilliam muliswilliam changed the base branch from feature/market-data-top-section to master March 31, 2022 19:24
@muliswilliam muliswilliam changed the base branch from master to markets-ratios-proxy April 4, 2022 14:15
@muliswilliam muliswilliam force-pushed the markets-ratios-proxy branch 3 times, most recently from 96b09ef to 1528329 Compare April 29, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Market Data Feature
1 participant