Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit top site dialog displays in the background instead of the foreground #23685

Closed
nightfury0448 opened this issue Jun 25, 2022 · 4 comments · Fixed by brave/brave-core#13975
Assignees
Labels
feature/new-tab OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@nightfury0448
Copy link

nightfury0448 commented Jun 25, 2022

Description

Edit top sites dialog displays in the background versus foreground. Can still make edits and save.

Steps to Reproduce

  1. Go to the new tab page and make sure there's a few top sites sites showing from most visited.
  2. Add site via the kebab menu or edit a tile to go into favorites mode.
  3. Notice Add Site/Edit dialog box. Move screen size or if many frequently visited/top sites are shown you'll see that dialog is in the background.

Actual result:

Screenshot (129)
edit site is not working properly

Expected result:

Edit dialog displays in the foreground

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Jun 27, 2022

cc: @fallaciousreasoning We have a regression where the dialog to edit sites is displaying in the background instead of the foreground.

@rebron rebron added feature/new-tab priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 27, 2022
@rebron rebron changed the title Edit site is not working Edit top site dialog displays in the background Jun 27, 2022
@rebron rebron changed the title Edit top site dialog displays in the background Edit top site dialog displays in the background instead of the foreground Jun 27, 2022
@fallaciousreasoning
Copy link

fallaciousreasoning commented Jun 27, 2022

I think this has probably been around for a while - the pagination on the NTP stuff hasn't landed yet. Fortunately the fix looks pretty straightforward, and should fix #23689 too.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

The above will require 1.41.94 or higher for 1.41.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 7, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jul 7, 2022

Verified with

Brave | 1.41.94 Chromium: 103.0.5060.114 (Official Build) (x86_64)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | macOS Version 12.4 (Build 21F79)

Using STR from #23685 (comment), reproduced the issue using 1.40.113. Observed add/edit dialog behind the grid of top tiles on NTP when adding or editing a site.

Add Site Edit Site
1 40 x add 1 40 x edit

Confirmed when using 1.41.94, the add and edit dialogs are not behind the top tiles grid.

Add Site Edit Site
1 41 x add 1 41 x edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants