-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sec-ch-ua
client hint should use the same product name regardless of the channel.
#25459
Labels
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
25 tasks
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Sep 20, 2022
Brand product name is used in the UA client hint string, but on MacOS our brand name varies based on the channel. This change assigns a fixed product name for when constructing the UA client hint string. Fixes brave/brave-browser#25459
This was referenced Sep 21, 2022
Merged
The above requires |
Verified
|
Brave | 1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (x86_64) |
---|---|
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707} |
OS | macOS Version 11.7 (Build 20G817) |
Steps:
- installed
1.45.87
- launched Brave
- opened
brave://flags
- set
Allow certain request client hints
toEnabled
- clicked on the
Relaunch
button - loaded
brave.com
with theDeveloper Tools
open to theNetwork
panel - clicked on
brave.com
- examined the
Request
headers and confirmed the following was present:
sec-ch-ua: "Chromium";v="106", "Brave";v="106", "Not;A=Brand";v="99"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "macOS"
brave://flags |
brave.com headers |
---|---|
Verification passed on
Steps:
|
Verified on
Steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
This is a follow up to #24009 (brave/brave-core#14155).
The code to generate the hint calls
version_info::GetProductName()
which on MacOS returns different values based on the channel (Beta, Nightly).@pes10k suggested to the value should be invariable for all channels.
Test plan:
See brave/brave-variations#332
The text was updated successfully, but these errors were encountered: