Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a 50/50 rollout of certain client hints in Nightly. #332

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Adds a 50/50 rollout of certain client hints in Nightly. #332

merged 1 commit into from
Sep 12, 2022

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Aug 19, 2022 •
edited by kjozwiak
Loading

Rollout for brave/brave-browser#24009 (brave/brave-core#14155)

Edited:

As mentioned via brave/brave-browser#24009 (comment), the original issue doesn't need AllowCertainClientHintsStudy:Enabled to complete verification. Because the website was fixed, QA will just make sure that everything, specifically the map is loading. We'll use the following issue for AllowCertainClientHintsStudy verification.

STR/Cases (after speaking with @mkarolin)

AllowCertainClientHintsStudy:Enabled

  • ensure that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform are appearing under the Request Headers

AllowCertainClientHintsStudy:Disabled

  • ensure that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform are not appearing under the Request Headers

@mkarolin mkarolin self-assigned this Aug 19, 2022
@mkarolin mkarolin requested a review from a team as a code owner August 19, 2022 20:02
@kjozwiak kjozwiak mentioned this pull request Sep 8, 2022
Closed
bsclifton
bsclifton approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 7ff7b64 into main Sep 12, 2022
@bsclifton bsclifton deleted the maxk-allow-certain-client-hints branch September 12, 2022 22:04
@kjozwiak
Copy link
Member

kjozwiak commented Sep 13, 2022 •
edited
Loading

Nightly channel (Desktop verification)

AllowCertainClientHintsStudy:Enabled (set as 50%)

Windows

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.45.41 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.918)

Launched 1.45.41 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

* sec-ch-ua: "Brave Browser";v"105", "Not)A;Brand";v="8", "Chromium";v="105"
* sec-ch-ua-mobile: ?0
* sec-ch-platform: "Windows"
Example Example
enabledGriffin requestHeadersGriffinEnabled

Linux

Verification PASSED on PopOS 22.04 x64 using the following build(s):

Brave | 1.45.43 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Linux

Launched 1.45.43 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

* sec-ch-ua: "Brave Browser";v="105", "Not)A;Brand";v="8", "Chromium";v="105"
* sec-ch-ua-mobile: ?0
* sec-ch-platform: "Linux"
Example Example
enabledLinux requestEnabled

macOS

Verification PASSED on macOS 12.5.1 Monterey x64 using the following build(s):

Brave | 1.45.41 Chromium: 105.0.5195.102 (Official Build) nightly (x86_64)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Launched 1.45.41 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

* sec-ch-ua: "Brave Browser Nightly";v="105", "Not)A;Brand";v="8", "Chromium";v="105"
* sec-ch-ua-mobile: ?0
* sec-ch-platform: "macOS"
Example Example
Screen Shot 2022-09-12 at 11 51 14 PM Screen Shot 2022-09-12 at 11 52 02 PM

AllowCertainClientHintsStudy:Disabled (set as 50%)

Windows

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.45.41 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.918)

Launched 1.45.41 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
disabledGriffin requestHeadersGriffinDisabled

Linux

Verification PASSED on PopOS 22.04 x64 using the following build(s):

Brave | 1.45.43 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Linux

Launched 1.45.43 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
image requestHeaderDisabled

macOS

Verification PASSED on macOS 12.5.1 Monterey x64 using the following build(s):

Brave | 1.45.41 Chromium: 105.0.5195.102 (Official Build) nightly (x86_64)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Launched 1.45.41 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
Screen Shot 2022-09-13 at 12 00 09 AM Screen Shot 2022-09-13 at 12 00 48 AM

BETA channel (Desktop verification)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.44.82 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.918)

Launched 1.44.82 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

image

Release channel (Desktop verification)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.43.89 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.918)

Launched 1.43.89 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

image

@kjozwiak
Copy link
Member

kjozwiak commented Sep 13, 2022 •
edited
Loading

Nightly channel (Android/Mobile verification)

AllowCertainClientHintsStudy:Enabled (set as 50%)

Verification PASSED on Samsung S10+ running Android 13 using the following build(s):

Brave | 1.45.43 Chromium: 105.0.5195.102 (Official Build) canary (32-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Android 12; Build/SP1A.210812.016

Launched 1.45.43 Chromium: 105.0.5195.102 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

* sec-ch-ua: "Brave Browser";v="105", "Not)A;Brand";v="8", "Chromium";v="105"
* sec-ch-ua-mobile: ?1
* sec-ch-platform: "Android"
Example Example
Screenshot_20220913-002623_Brave - Nightly requestEnabled

AllowCertainClientHintsStudy:Disabled (set as 50%)

Verification PASSED on Samsung S10+ running Android 13 using the following build(s):

Brave | 1.45.43 Chromium: 105.0.5195.102 (Official Build) canary (32-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Android 12; Build/SP1A.210812.016

Launched 1.45.43 Chromium: 105.0.5195.102 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
Screenshot_20220913-002331_Brave - Nightly requestDisabled

BETA channel (Android/Mobile verification)

Verification PASSED on Samsung S10+ running Android 13 using the following build(s):

Brave | 1.44.82 Chromium: 105.0.5195.102 (Official Build) beta (32-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Android 12; Build/SP1A.210812.016

Launched 1.44.82 Chromium: 105.0.5195.102 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

Screenshot_20220913-003804_Brave - Beta

Release channel (Android/Mobile verification)

Verification PASSED on Samsung S10+ running Android 13 using the following build(s):

Brave | 1.43.90 Chromium: 105.0.5195.102 (Official Build) (32-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Android 12; Build/SP1A.210812.016

Launched 1.43.90 Chromium: 105.0.5195.102 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

Screenshot_20220913-004250_Brave

@kjozwiak kjozwiak mentioned this pull request Sep 13, 2022
Merged
@mkarolin mkarolin mentioned this pull request Sep 16, 2022
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2022 •
edited
Loading

Nightly channel (Desktop verification)

AllowCertainClientHintsStudy:Enabled (set as 50%)

Windows

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) nightly (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 11 Version 22H2 (Build 22621.521)

Launched 1.46.32 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

sec-ch-ua: "Chromium";v="106", "Brave";v="106", "Not;A=Brand";v="99"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "Windows"
Example Example
hintsEnabledGriffin hintsEnabledDevTools

Linux

Verification PASSED on PopOS 22.04 x64 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) nightly (64-bit) 
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Linux

Launched 1.46.32 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

sec-ch-ua: "Chromium";v="106", "Brave";v="106", "Not;A=Brand";v="99"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "Linux"
Example Example
image clientHintsEnabled

macOS

Verification PASSED on macOS 12.6 Monterey x64 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) nightly (x86_64)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | macOS Version 12.6 (Build 21G115)

Launched 1.45.41 Chromium: 105.0.5195.102 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

sec-ch-ua: "Chromium";v="106", "Brave";v="106", "Not;A=Brand";v="99"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "macOS"
Example Example
Screen Shot 2022-10-04 at 1 27 58 PM Screen Shot 2022-10-04 at 1 28 10 PM

AllowCertainClientHintsStudy:Disabled (set as 50%)

Windows

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) nightly (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 11 Version 22H2 (Build 22621.521)

Launched 1.46.32 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
hintsDisabled hintsDisabledDevTools

Linux

Verification PASSED on PopOS 22.04 x64 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) nightly (64-bit)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Linux

Launched 1.46.32 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
image linuxDisabled

macOS

Verification PASSED on macOS 12.5.1 Monterey x64 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) nightly (x86_64) 
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | macOS Version 12.6 (Build 21G115)

Launched 1.46.32 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
Screen Shot 2022-10-04 at 1 46 57 PM Screen Shot 2022-10-04 at 1 47 24 PM

BETA channel (Desktop verification)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.45.85 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 11 Version 22H2 (Build 22621.521)

Launched 1.45.85 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

image

Release channel (Desktop verification)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.44.105 Chromium: 106.0.5249.91 (Official Build) (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 11 Version 22H2 (Build 22621.521)

Launched 1.44.105 Chromium: 106.0.5249.91 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

image

@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2022

Nightly channel (Android/Mobile verification)

AllowCertainClientHintsStudy:Enabled (set as 50%)

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) canary (32-bit)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Android 12; Build/SP1A.210812.016

Launched 1.46.32 Chromium: 106.0.5249.91 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

sec-ch-ua: "Chromium";v="106", "Brave";v="106", "Not;A=Brand";v="99"
sec-ch-ua-mobile: ?1
sec-ch-ua-platform: "Android"
Example Example
Screenshot_20221004-145357_Brave - Nightly androidDevToolsEnabled

AllowCertainClientHintsStudy:Disabled (set as 50%)

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.46.32 Chromium: 106.0.5249.91 (Official Build) canary (32-bit)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Android 12; Build/SP1A.210812.016

Launched 1.46.32 Chromium: 106.0.5249.91 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

  • ensured that sec-ch-ua, sec-ch-ua-mobile & sec-ch-platform weren't present via the Request Headers
Example Example
Screenshot_20221004-144539_Brave - Nightly androidDevToolsDisabled

BETA channel (Android/Mobile verification)

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.45.85 Chromium: 106.0.5249.91 (Official Build) beta (32-bit)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Android 12; Build/SP1A.210812.016

Launched 1.45.85 Chromium: 106.0.5249.91 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

Screenshot_20221004-152337_Brave - Beta

Release channel (Android/Mobile verification)

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.44.105 Chromium: 106.0.5249.91 (Official Build) (32-bit)
--- | ---
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Android 12; Build/SP1A.210812.016

Launched 1.44.105 Chromium: 106.0.5249.91 using the instructions outlined via brave/brave-core#10408 (comment) and ensured the following:

  • ensured that AllowCertainClientHintsStudy wasn't appearing/being displayed under brave://version
    • ensured that AllowCertainClientHintsStudy:Enabled never appeared under brave://version
    • ensured that AllowCertainClientHintsStudy:Disabled never appeared under brave://version

Screenshot_20221004-153147_Brave

This was referenced Nov 9, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @kjozwiak @bsclifton