Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Remove from list menu entry to download bubble context menu #29475

Closed
simonhong opened this issue Apr 3, 2023 · 1 comment · Fixed by brave/brave-core#17976
Closed

Add Remove from list menu entry to download bubble context menu #29475

simonhong opened this issue Apr 3, 2023 · 1 comment · Fixed by brave/brave-core#17976
Assignees
@simonhong
Labels
feature/download OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Apr 3, 2023 •
edited
Loading

When user clicks download button, download bubble is shown and it shows all items.
Add Remove from list menu entry to the below context menu in each item.
With that, user could remove item from download bubble directly instead of going to download page.

Remove from list should be visible only for completed or cancelled download item.

Screenshot 2023-04-10 at 4 57 17 PM
@simonhong simonhong self-assigned this Apr 3, 2023
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/download labels Apr 7, 2023
@simonhong simonhong mentioned this issue Apr 10, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Apr 11, 2023
@simonhong
Added remove from list menu entry to download bubble item
545f973 
fix brave/brave-browser#29475

Added remove from list entry to  completed and cancelled items in download bubble.
@simonhong simonhong changed the title Add Remove item from the list menu entry to download bubble context menu Add Remove from list menu entry to download bubble context menu Apr 11, 2023
@bsclifton bsclifton added this to the 1.52.x - Nightly milestone Apr 11, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.52.37 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2846)

Steps:

  1. installed 1.52.37
  2. launched Brave
  3. loaded https://www.leaseweb.com/platform/network
  4. downloaded 10000mb.bin from the San Francisco... link, to the right
  5. downloaded BraveBrowserStandaloneNightlySetup.exe
  6. context-clicked on the .exe file and chose Remove from list
  7. did the same, for the completed 10000mb.bin file
  8. confirmed I could remove the completed download from the list
example example example example example
image (1) image (2) image image image

@simonhong simonhong mentioned this issue Apr 17, 2023
Open
@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/download OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Added remove from list menu entry to download bubble item brave/brave-core
4 participants
@stephendonner @bsclifton @rebron @simonhong