Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads bubble doesn't popup when the download is blocked/dangerous (safe browsing disabled) #29651

Closed
ghost opened this issue Apr 12, 2023 · 15 comments · Fixed by brave/brave-core#18243

Comments

@ghost
Copy link

ghost commented Apr 12, 2023

Description

@simonhong there is an tiny little bug with the Downloads bubble, where if you disable Safe browsing and a 'dangerous' downloaded is blocked, the bubble doesn't popup, and the only way to download the file is by going to downloads page (ctrl+j) and click keep and then keep it anyway.

The easiest way to reproduce this is by creating a new profile, but I noticed it is also affecting my normal profile where I have never had Safe Browsing enabled.

The bug seems to get resolved in normal windows if you click keep and then keep anyway, in my test, new downloads are working as expected after doing that, even on restart.
Also, it worked fine when I had Safe Browsing on and downloaded a file, and then disabled it.

I guess the problem seems to be bigger for InPrivate windows though, because I noticed that if you download a file and 'fix' the issue by keeping the file, once you close the window and open a new InPrivate window and try to download a 'dangerous' file again, the bubble will not popup until you keep it and keep it anyway again.

Steps to Reproduce

  1. Create new profile/User Data.
  2. go to brave://settings/security and disable Safe Browsing.
  3. Go to https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  4. Nothing seems to happen
  5. Go to downloads page, and the download should only appear there to discard it or keep it
  6. (optional) Discard it and go back to the page and try to download the file again to confirm it still doesn't work.
  7. Click keep and then keep anyway
  8. Future downloads should show the bubble as expected (until it doesn't)

Actual result:

brave_2023-04-12_04-19-29

Brave version (brave://version info)

1.52.36 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit) - Windows 11 Pro 21H2 22000.1696

@ghost ghost added the OS/Desktop label Apr 12, 2023
@simonhong
Copy link
Member

@Emi-TheDhamphirInLoveUnderTheFrozenStar Thanks for reporting. I'll take a look.

@simonhong simonhong self-assigned this Apr 24, 2023
@simonhong
Copy link
Member

simonhong commented Apr 24, 2023

According to the comment below, dangerous download is considered as a completed.

  // From the button UI's perspective, whether the download is considered in
  // progress. Consider dangerous downloads as completed, because we don't want
  // to encourage users to interact with them. However, consider downloads
  // pending scanning as in progress, because we do want users to scan potential
  // dangerous downloads.

Below method determines whether toolbar button should be shown(ShowToolbarButton()) or hide(HideToolbarButton()).
When all current active downloadings are dangerous files, info.in_progress_count is zero because of above comment.
So, icon_info_.icon_state = DownloadIconState::kComplete;.
To show download button, ShowToolbarButton(); should be called but it's called
when icon_state is not kComplete and there was no recently completed download.
So, we can repro this easily with fresh profile to not have recent download.

@Emi-TheDhamphirInLoveUnderTheFrozenStar What you're seeing is expected behavior with current implementation.
but we want to show download button even current downloading is only for dangerous file.
I'm not sure this is upstream's intended behavior or not but IMO button should be visible in this situation also.

void DownloadDisplayController::UpdateToolbarButtonState(
    std::vector<std::unique_ptr<DownloadUIModel>>& all_models) {
  if (all_models.empty()) {
    HideToolbarButton();
    return;
  }
  AllDownloadUIModelsInfo info = GetAllModelsInfo(all_models);
  base::Time last_complete_time = GetLastCompleteTime(all_models);

  if (info.in_progress_count > 0) {
    icon_info_.icon_state = DownloadIconState::kProgress;
    icon_info_.is_active = info.paused_count < info.in_progress_count;
  } else {
    icon_info_.icon_state = DownloadIconState::kComplete;
    bool complete_unactioned =
        HasRecentCompleteDownload(kToolbarIconActiveTimeInterval,
                                  last_complete_time) &&
        info.has_unactioned;
    bool exited_fullscreen_owed_details =
        !display_->IsFullscreenWithParentViewHidden() &&
        details_shown_while_fullscreen_;
    if (complete_unactioned || exited_fullscreen_owed_details) {
      icon_info_.is_active = true;
      ScheduleToolbarInactive(kToolbarIconActiveTimeInterval);
    } else {
      icon_info_.is_active = false;
    }
  }

  if (info.has_deep_scanning) {
    icon_info_.icon_state = DownloadIconState::kDeepScanning;
  }

  if (icon_info_.icon_state != DownloadIconState::kComplete ||
      HasRecentCompleteDownload(kToolbarIconVisibilityTimeInterval,
                                last_complete_time)) {
    ShowToolbarButton();
  }
  display_->UpdateDownloadIcon(/*show_animation=*/false);
}

@stephendonner
Copy link

stephendonner commented May 31, 2023

Verification PASSED using

Brave 1.53.83 Chromium: 114.0.5735.110 (Official Build) beta (x86_64)
Revision 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS macOS Version 11.7.7 (Build 20G1345)

Safe Browsing disabled - PASSED

Steps:

  1. installed 1.53.83
  2. launched Brave
  3. toggled Safe Browsing to No Protection in brave://settings/security
  4. confirmed warning about disabling Safe Browsing
  5. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  6. confirmed auto-download save-as-file location-picker dialog (!) came up
  7. clicked Save
  8. confirmed file downloaded without additional warnings
  9. cleared file
  10. repeated steps 5-8
example example example example example example
Screen Shot 2023-06-06 at 5 03 46 PM Screen Shot 2023-06-06 at 5 03 49 PM Screen Shot 2023-06-06 at 5 04 12 PM Screen Shot 2023-06-06 at 5 04 17 PM Screen Shot 2023-06-06 at 5 04 21 PM Screen Shot 2023-06-06 at 11 37 16 AM

Safe Browsing enabled (Standard protection; default) - PASSED

Steps:

  1. installed 1.53.83
  2. launched Brave
  3. confirmed Safe Browsing was set to Standard Protection in brave://settings/security
  4. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. confirmed auto-download save-as-file location-picker dialog (!) came up
  6. clicked Save
  7. confirmed file downloaded without additional warnings
  8. cleared file
  9. repeated steps 4-7

Also tried with https://www.audacityteam.org/download/mac/ and https://mac.softpedia.com/get/System-Utilities/AppCleaner.shtml (and others, not pictured)

example example example example example example example example
Screen Shot 2023-06-06 at 5 15 25 PM Screen Shot 2023-06-06 at 5 15 55 PM Screen Shot 2023-06-06 at 5 16 00 PM Screen Shot 2023-06-06 at 5 16 30 PM Screen Shot 2023-06-06 at 5 16 41 PM Screen Shot 2023-06-06 at 5 33 34 PM Screen Shot 2023-06-06 at 5 42 10 PM Screen Shot 2023-06-06 at 5 42 15 PM

Blocked downloads

Blocked, Insecure - PASSED

Steps:

  1. installed 1.53.84
  2. launched Brave
  3. loaded https://testsafebrowsing.appspot.com/
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/content.exe
Screenshot 2023-06-07 at 2 14 03 AM

Blocked, Dangerous - PASSED

Steps:

  1. installed 1.53.84
  2. launched Brave
  3. loaded https://testsafebrowsing.appspot.com
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/badrep.exe
Screenshot 2023-06-07 at 2 06 54 AM

Blocked, Uncommon file - PASSED

Steps:

  1. installed 1.53.84
  2. launched Brave
  3. opened https://testsafebrowsing.appspot.com
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/unknown.exe
Screenshot 2023-06-07 at 2 12 27 AM

Keep flow - PASSED

Keep dangerous file Keep anyway Downloaded file
Screenshot 2023-06-07 at 2 15 16 AM Screenshot 2023-06-07 at 2 16 14 AM Screenshot 2023-06-07 at 2 16 18 AM

Encountered:

NOTE: I will retest the above scenarios in #30882 once it lands 👍

@stephendonner
Copy link

@simonhong mind reviewing my steps and results, from above, before I mark it as QA Pass-macOS? Maybe macOS and Windows have different ideas of what "dangerous files" are? I checked with 1.52.116 on macOS, and it behaves the same as above, in both cases, also 🤷

@simonhong
Copy link
Member

@simonhong mind reviewing my steps and results, from above, before I mark it as QA Pass-macOS? Maybe macOS and Windows have different ideas of what "dangerous files" are? I checked with 1.52.116 on macOS, and it behaves the same as above, in both cases, also 🤷

Hmm, I also can't repro anymore. it's always treated as normal download file..
Not sure but could it be possible that this file link was danger but changed to safe now? :)
don't know much about how safe browsing works.

@stephendonner
Copy link

stephendonner commented May 31, 2023

@simonhong mind reviewing my steps and results, from above, before I mark it as QA Pass-macOS? Maybe macOS and Windows have different ideas of what "dangerous files" are? I checked with 1.52.116 on macOS, and it behaves the same as above, in both cases, also 🤷

Hmm, I also can't repro anymore. it's always treated as normal download file.. Not sure but could it be possible that this file link was danger but changed to safe now? :) don't know much about how safe browsing works.

OK, I'll redo the Safe Browsing Enabled case using https://www.leaseweb.com/platform/network, then, as that triggers the dialog, I now recall:

Screen Shot 2023-05-30 at 11 56 22 PM

EDIT: No, the above is for scheme-mismatch (i.e. HTTP vs. HTTPS-originated downloads) only, sorry.

So there are at least INSECURE and DANGEROUS-file-statuses.

@stephendonner
Copy link

@simonhong @rebron can you/the team take a look at #30626 when you get a chance? I keep running into it on both nightly and beta, when trying to test this issue and around the area, too. Thanks!

@simonhong
Copy link
Member

@simonhong @rebron can you/the team take a look at #30626 when you get a chance? I keep running into it on both nightly and beta, when trying to test this issue and around the area, too. Thanks!

I'll take a look

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 6, 2023

Verification PASSED using

Brave | 1.53.82 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Case 1: Safe Browsing disabled - PASSED

  1. installed 1.53.74
  2. launched Brave
  3. selected No Protection radio button for Safe Browsing in brave://settings/security
  4. confirmed warning about Turn off Safe Browsing?
  5. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  6. clicked Save in the Save-as Downloads dialog
  7. confirmed download button is shown in the toolbar
  8. clicked on download button
  9. clicked Keep
  • Confirmed download button shown for blocked/dangerous downloads
  • Confirmed when clicked Keep button, warning message shown
step 4 step 4a step 6 step 7 step 8 step 9 ex ex
image image image image image image image image

Continue from Case 1:

  1. clicked x previous download in brave://downloads
  2. repeated steps 5-8
  3. clicked Discard /Delete
  4. reload the https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. clicked Save

Confirmed download button is shown with warning bubble when clicked the button

ex ex ex
image image image

Safe Browsing enabled (Standard protection; default) - PASSED

Steps:

  1. new profile
  2. launched Brave
  3. confirmed Safe Browsing was set to Standard Protection in brave://settings/security
  4. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. clicked Save in the Save-as Downloads dialog
  6. clicked Save
  7. clicked on download button

Confirmed no additional warnings shown in the bubble and the file downloaded

ex ex ex
image image image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 6, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 7, 2023
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 8, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 9, 2023
@stephendonner
Copy link

stephendonner commented Jun 9, 2023

Verification PASSED using

Brave 1.53.87 Chromium: 114.0.5735.110 (Official Build) beta (64-bit) 
Revision 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS Linux

Case 1: Safe Browsing disabled - PASSED

Steps:

  1. installed 1.53.87
  2. launched Brave
  3. opened brave://settings/security
  4. toggled Safe Browsing to No protection (not recommended)
  5. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  6. waited for auto-download file-picker Save file as... dialog to appear
  7. clicked on Save
  8. confirmed file saved without warning dialogs
Step 4a Step 4b Step 5 Step 6 Step 7 Step 8
Screen Shot 2023-06-09 at 11 08 14 AM Screen Shot 2023-06-09 at 11 08 23 AM Screen Shot 2023-06-09 at 11 13 20 AM Screen Shot 2023-06-09 at 11 13 25 AM Screen Shot 2023-06-09 at 11 13 32 AM Screen Shot 2023-06-09 at 11 13 40 AM

Case 2: Safe Browsing enabled - PASSED

Steps:

  1. installed 1.53.87
  2. launched Brave
  3. confirmed default Safe Browsing pref is set to Standard protection
  4. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. waited for auto-download file-picker Save file as... dialog to appear
  6. clicked on Save
  7. confirmed file saved without warning dialogs
Step 3 Step 4 Step 5 Step 6 Step 7
Screen Shot 2023-06-09 at 11 27 48 AM Screen Shot 2023-06-09 at 11 29 23 AM Screen Shot 2023-06-09 at 11 30 21 AM Screen Shot 2023-06-09 at 11 30 26 AM Screen Shot 2023-06-09 at 11 30 36 AM

Case 3: Uncommon/malicious file - PASSED

Steps:

  1. installed 1.53.87
  2. launched Brave
  3. loaded https://testsafebrowsing.appspot.com/
  4. context-clicked on https://testsafebrowsing.appspot.com/s/bad_app_file_on_scan.exe
  5. clicked Save
  6. confirmed file-download animation, highlighting the Downloads bubble/button, which has now changed to a down arrow with blue highlight
  7. clicked on the above
  8. confirmed file-download status is Blocked - uncommon file
  9. clicked on Continue download
  10. waited for download to finish, and examined its state

Confirmed I got the auto-download popup, the bubble opened when clicked on, showed successful "blocked" state, and I was able to Continue download to completion

Step 3 Step 5 Step 6 Step 7 Steps 8-9 Step 10
Screen Shot 2023-06-09 at 11 44 10 AM Screen Shot 2023-06-09 at 11 43 08 AM Screen Shot 2023-06-09 at 11 43 15 AM Screen Shot 2023-06-09 at 11 43 29 AM Screen Shot 2023-06-09 at 11 43 33 AM Screen Shot 2023-06-09 at 11 43 40 AM
---

Note: Comparison to 1.51.114

1.53.87 1.51.114
one-fifty-three-works one-fifty-1-works

Encountered:

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 9, 2023
kjozwiak pushed a commit to brave/brave-core that referenced this issue Jul 5, 2023
…lift to 1.52.x) (#19151)

* Fixed download button is not shown when dangerous file downloaded

fix brave/brave-browser#29651

* [113.0.5672.63 follow up] Fix build failure.

Chromium changes:

https://source.chromium.org/chromium/chromium/src/+/e1a48ccd6d3ea6fb6bd8a9d82cecd4cad1b3a202

commit e1a48ccd6d3ea6fb6bd8a9d82cecd4cad1b3a202
Author: Lily Chen <chlily@chromium.org>
Date:   Fri Apr 21 20:11:47 2023 +0000

    [DownloadBubble] Compute info relevant to button state in update service

    This moves the computation of the AllDownloadUIModelsInfo from the
    per-window DownloadDisplayController to the per-profile
    DownloadBubbleUpdateService. This avoids redundant fetching of models
    from the update service, which is expensive and potentially causes jank
    while downloading files, since the models are not needed (just the info
    about them) in order to update the button state.

    Bug: 1434670

https://source.chromium.org/chromium/chromium/src/+/3381daf526425ad5b99d5678adab03c073531531

commit 3381daf526425ad5b99d5678adab03c073531531
Author: Lily Chen <chlily@chromium.org>
Date:   Fri Apr 21 12:57:07 2023 +0000

    [DownloadBubble] Defer GetDownloadManager() calls

    This defers calls to GetDownloadManager() to avoid calling it
    at startup, which may be expensive as it may cause the
    DownloadManager to be created immediately. These calls were
    potentially causing large performance regressions in
    startup time when the download bubble is enabled.

    This fixes 3 places:

    1. DownloadBubbleUpdateService: This CL now splits the
       initialization of the service, adding a separate function to
       start listening to the DownloadManager (by creating an
       AllDownloadItemNotifier) after the DownloadManager is ready.
       This function is called from DownloadUIController's ctor,
       which runs immediately after the DownloadManager has been
       created by DownloadCoreService in GetDownloadManagerDelegate.

    2. DownloadBubbleUIController: This CL removes the ctor
       call to GetDownloadManager() in favor of getting the manager
       only when needed, i.e. when retrying a download, by which
       time the manager should be initialized.

    3. DownloadDisplayController: This was calling
       GetDownloadManager() on construction (i.e. startup)
       completely unnecessarily, to get the DownloadPrefs, which
       also has a getter based on BrowserContext.

    Bug: 1421426

---------

Co-authored-by: Simon Hong <shong@brave.com>
Co-authored-by: Max Karolinskiy <max@brave.com>
@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2023

The above requires 1.52.130 or higher for 1.52.x verification 👍 Removing the QA Pass labels as the above will need to be rechecked with 1.52.x.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 6, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 6, 2023

Verified with

Brave | 1.52.130 Chromium: 114.0.5735.198 (Official Build) (x86_64)
-- | --
Revision | c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS | macOS Version 13.4.1 (Build 22F82)

Safe Browsing disabled - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave
  3. toggled Safe Browsing to No Protection in brave://settings/security
  4. confirmed warning about disabling Safe Browsing
  5. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  6. confirmed auto-download save-as-file location-picker dialog (!) came up
  7. clicked Save
  8. confirmed file downloaded without additional warnings
  9. cleared file
  10. repeated steps 5-8
example example example example
1 2 3 4

Safe Browsing enabled (Standard protection; default) - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 minutes and confirmed Safe Browsing was downloaded before proceeding with the rest of the steps
  3. confirmed Safe Browsing was set to Standard Protection in brave://settings/security
  4. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. confirmed auto-download save-as-file location-picker dialog (!) came up
  6. clicked Save
  7. confirmed file downloaded without additional warnings
  8. cleared file
  9. repeated steps 4-7

Also tried with https://www.audacityteam.org/download/mac/

example example example example
1 2 3 4

Blocked downloads

Blocked, Dangerous - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 min and confirmed Safe Browsing was downloaded before proceeding
  3. loaded https://testsafebrowsing.appspot.com/
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/content.exe
Example Example
1 2

Blocked, Uncommon file - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 min and confirmed Safe Browsing was downloaded before proceeding
  3. opened https://testsafebrowsing.appspot.com
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/unknown.exe
Example Example
1 2

Keep flow - PASSED

Keep dangerous file Keep anyway Downloaded file
1 2 3

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 6, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.130 Chromium: 114.0.5735.198 (Official Build) (64-bit)
-- | --
Revision | c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS | Linux

Safe Browsing disabled - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave
  3. toggled Safe Browsing to No Protection in brave://settings/security
  4. confirmed warning about disabling Safe Browsing
  5. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  6. confirmed auto-download save-as-file location-picker dialog (!) came up
  7. clicked Save
  8. confirmed file downloaded without additional warnings
  9. cleared file
  10. repeated steps 5-8
example example example example example example
Screenshot from 2023-07-06 09-41-06 Screenshot from 2023-07-06 09-41-24 Screenshot from 2023-07-06 09-42-42 Screenshot from 2023-07-06 09-42-57 Screenshot from 2023-07-06 09-43-16 Screenshot from 2023-07-06 09-44-49

Safe Browsing enabled (Standard protection; default) - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 minutes and confirmed Safe Browsing was downloaded before proceeding with the rest of the steps
  3. confirmed Safe Browsing was set to Standard Protection in brave://settings/security
  4. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. confirmed auto-download save-as-file location-picker dialog (!) came up
  6. clicked Save
  7. confirmed file downloaded without additional warnings
  8. cleared file
  9. repeated steps 4-7
example example example example example
Screenshot from 2023-07-06 10-42-01 Screenshot from 2023-07-06 10-43-09 Screenshot from 2023-07-06 10-43-36 Screenshot from 2023-07-06 10-43-45 image

Blocked downloads

Blocked, Dangerous - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 min and confirmed Safe Browsing was downloaded before proceeding
  3. loaded https://testsafebrowsing.appspot.com/
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/content.exe
Example Example
Screenshot from 2023-07-06 10-55-46 Screenshot from 2023-07-06 10-56-07

Blocked, Uncommon file - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 min and confirmed Safe Browsing was downloaded before proceeding
  3. opened https://testsafebrowsing.appspot.com
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/unknown.exe
Example Example
image image

Keep flow - PASSED

Keep dangerous file Keep anyway Downloaded file
image image image

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 6, 2023
@stephendonner
Copy link

stephendonner commented Jul 6, 2023

Verification PASSED using

Brave	1.52.130 Chromium: 114.0.5735.198 (Official Build) (64-bit) 
Revision	c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS	Windows 10 Version 22H2 (Build 19045.3155)

Safe Browsing disabled - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave
  3. toggled Safe Browsing to No Protection in brave://settings/security
  4. confirmed warning about disabling Safe Browsing
  5. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  6. confirmed file picker dialog automatically came up
  7. clicked Save
  8. confirmed file downloaded without additional warnings
  9. cleared file
  10. repeated steps 5-8
example example example example
image image image image

Safe Browsing enabled (Standard protection; default) - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave
  3. waited ~8 minutes and confirmed Safe Browsing downloaded
  4. loaded https://www.majorgeeks.com/mg/get/fort_firewall,2.html
  5. confirmed auto-download file-picker dialog came up
  6. clicked Save
  7. confirmed file download without additional warnings
  8. cleared file
  9. repeated steps 4-7
example example example example
image image image image

Blocked downloads

Blocked, dangerous - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 min and confirmed Safe Browsing was downloaded before proceeding
  3. loaded https://testsafebrowsing.appspot.com/
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/content.exe
example example
image (2) image (3)

Blocked, Uncommon file - PASSED

Steps:

  1. installed 1.52.130
  2. launched Brave, waited ~8 min and confirmed Safe Browsing was downloaded before proceeding
  3. opened https://testsafebrowsing.appspot.com
  4. clicked on and saved https://testsafebrowsing.appspot.com/s/unknown.exe
example example
image image (1)

Keep flow - PASSED

Blocked - dangerous Keep dangerous file / Keep anyway Downloaded file
image image (3) image (4)

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment