Fixed download button is not shown when dangerous file downloaded (uplift to 1.52.x) #19151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium changes: https://source.chromium.org/chromium/chromium/src/+/e1a48ccd6d3ea6fb6bd8a9d82cecd4cad1b3a202 commit e1a48ccd6d3ea6fb6bd8a9d82cecd4cad1b3a202 Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 21 20:11:47 2023 +0000 [DownloadBubble] Compute info relevant to button state in update service This moves the computation of the AllDownloadUIModelsInfo from the per-window DownloadDisplayController to the per-profile DownloadBubbleUpdateService. This avoids redundant fetching of models from the update service, which is expensive and potentially causes jank while downloading files, since the models are not needed (just the info about them) in order to update the button state. Bug: 1434670 https://source.chromium.org/chromium/chromium/src/+/3381daf526425ad5b99d5678adab03c073531531 commit 3381daf526425ad5b99d5678adab03c073531531 Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 21 12:57:07 2023 +0000 [DownloadBubble] Defer GetDownloadManager() calls This defers calls to GetDownloadManager() to avoid calling it at startup, which may be expensive as it may cause the DownloadManager to be created immediately. These calls were potentially causing large performance regressions in startup time when the download bubble is enabled. This fixes 3 places: 1. DownloadBubbleUpdateService: This CL now splits the initialization of the service, adding a separate function to start listening to the DownloadManager (by creating an AllDownloadItemNotifier) after the DownloadManager is ready. This function is called from DownloadUIController's ctor, which runs immediately after the DownloadManager has been created by DownloadCoreService in GetDownloadManagerDelegate. 2. DownloadBubbleUIController: This CL removes the ctor call to GetDownloadManager() in favor of getting the manager only when needed, i.e. when retrying a download, by which time the manager should be initialized. 3. DownloadDisplayController: This was calling GetDownloadManager() on construction (i.e. startup) completely unnecessarily, to get the DownloadPrefs, which also has a getter based on BrowserContext. Bug: 1421426
emerick
force-pushed
the
download_button_danger_file_1.52.x
branch
from
2a6bfb6
to
e53592d
Compare
kjozwiak
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Uplift into 1.52.x approved 👍 QA has verified the PR on 1.53.x (BETA) as per brave/brave-browser#29651 (comment) & brave/brave-browser#29651 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #18243