Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Restore All" to "Clear Excluded List" in ac #4474

Closed
srirambv opened this issue May 16, 2019 · 2 comments · Fixed by brave/brave-core#15029
Closed

Rename "Restore All" to "Clear Excluded List" in ac #4474

srirambv opened this issue May 16, 2019 · 2 comments · Fixed by brave/brave-core#15029
Assignees

Comments

@srirambv
Copy link
Contributor

Description

With #3459 implementation excluded site isn't restored when you click on Restore all so the term Restore all is quite confusing and doesn't really make sense. Since we are removing sites from the db for that month, renaming to Clear Exclude List makes more sense.

Steps to Reproduce

  1. Install 0.64.x build
  2. Visit a site and add to ac list
  3. Exclude site, ensure Restore all message is shown
  4. Click Restore all, nothing gets restored as its removed from db

Actual result:

Go into think mode of simpler times when restore meant bringing back something that was gone

Expected result:

Clear means remove, restore means bring back

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.64.76 Chromium: 74.0.3729.157 (Official Build) (64-bit)
Revision 7b16107ab85c5364cdcd0b2dea2539a1f2dc327a-refs/branch-heads/3729@{#998}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes because we released with this bug
  • Can you reproduce this issue with the beta channel?
    Should be
  • Can you reproduce this issue with the dev channel?
    Definitely
  • Can you reproduce this issue with the nightly channel?
    Undoubtedly

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @NejcZdovc @mandar-brave @brave/legacy_qa

@NejcZdovc NejcZdovc removed the QA/Yes label Apr 10, 2020
@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Aug 31, 2022
mkarolin added a commit to brave/brave-core that referenced this issue Sep 7, 2022
Replaced "Restore All" with "Clear exclude list" and "Restore this site"
tooltip text with "Remove from excluded".

Fixes brave/brave-browser#4474
@mkarolin mkarolin added this to the 1.45.x - Nightly milestone Sep 8, 2022
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 10 Version 21H2 (Build 19044.2006)

Example Example
image image

@LaurenWags
Copy link
Member

LaurenWags commented Oct 14, 2022

Verified on Google Pixel 3 XL with Android 12 running 1.45.100

  • Confirmed updated wording on the AC sites popup for both the link and tooltip text

Screenshot_20221014-114806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants