Rewards AC exclusions text changes. #15029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Replaced "Restore All" with "Clear exclude list" and "Restore this site" tooltip text with "Remove from excluded". Fixes brave/brave-browser#4474
mkarolin
force-pushed
the
maxk-update-ac-exclude-text
branch
from
e2199fe
to
262a903
Compare
zenparsing
approved these changes
Sep 7, 2022
| : getLocale('excludeSite') | ||
|
|
||
| cell.content.push({ | ||
| content: ( | ||
| <Tooltip content={actionTooltip}> | ||
| <Tooltip rightEdge={true} content={actionTooltip}> |
There was a problem hiding this comment.
What does rightEdge do?
There was a problem hiding this comment.
It moves the tooltip to be to the left of the button (instead of being centered on the button). If I leave it centered the tooltip doesn't fit and we end up with a scrollbar.
There was a problem hiding this comment.
Ah, I see. I'm curious if we even need the tooltip - seems kind of obvious what the "x" does 😆
There was a problem hiding this comment.
Yeah, probably not really necessary, but it was already there 😄
|
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced "Restore All" with "Clear exclude list" and "Restore this site" tooltip text with "Remove from excluded".
Fixes brave/brave-browser#4474
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: