Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reddit Panel For Tipping #4745

Closed
jasonrsadler opened this issue Jun 6, 2019 · 3 comments · Fixed by brave/brave-core#2624
Closed

Implement Reddit Panel For Tipping #4745

jasonrsadler opened this issue Jun 6, 2019 · 3 comments · Fixed by brave/brave-core#2624

Comments

@jasonrsadler
Copy link

Description

Implement Reddit panel tipping for Rewards

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 2, 2019

Verification passed on

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

image

image

image

  • Verified the pubs name is displayed properly in BR panel and tipping banner for verified and unverified pubs in old Reddit layout
    image

image

image

image

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2624

New reddit:
image
image
image

Old reddit:
image
image
image

Verified passed with

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

reddit.com (unverified publisher):
Screen Shot 2019-08-16 at 3 47 24 PM
Screen Shot 2019-08-16 at 3 47 31 PM

np.reddit.com (verified publisher but no favicon):
Screen Shot 2019-08-16 at 3 46 43 PM
Screen Shot 2019-08-16 at 3 46 51 PM

  • Verified custom banner displays for verified reddit publisher
    Screen Shot 2019-08-16 at 3 37 06 PM

  • Verified pending contributions (from tips) for unverified pubs display in pending table and link to correct reddit publisher.
    Screen Shot 2019-08-16 at 3 38 26 PM
    Screen Shot 2019-08-16 at 3 38 59 PM

  • in line tipping tested under Implement Reddit inline tipping for flat menu #4915

  • Verified tips display in tips panel and link to correct reddit publishers.

  • If user has a custom favicon on reddit, it is used on BAT rewards panel and on tips pane on brave://rewards. If user does not have a custom favicon, the generic reddit favicon is used. Note - in both cases the verified checkmark is displayed if applicable.
    Screen Shot 2019-08-16 at 3 43 34 PM

@DimitrisHol
Copy link

DimitrisHol commented Aug 31, 2019

Is there a way to disable this on the frontpage?

@NejcZdovc
Copy link
Contributor

@DimitrisHol there is option to disable it, but just all or nothing. Sadly you can't disable just portions of the inline tipping on Reddit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment