Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reddit inline tipping for flat menu #4915

Closed
jasonrsadler opened this issue Jun 14, 2019 · 1 comment · Fixed by brave/brave-core#2665
Closed

Implement Reddit inline tipping for flat menu #4915

jasonrsadler opened this issue Jun 14, 2019 · 1 comment · Fixed by brave/brave-core#2665

Comments

@jasonrsadler
Copy link

Description

Implement Reddit inline tipping for menu that appears at bottom of posts/comments (flat menu)

New feature request

jasonrsadler pushed a commit to brave/brave-core that referenced this issue Jun 20, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Jun 21, 2019
@jasonrsadler jasonrsadler added this to the 0.68.x - Nightly milestone Jun 21, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 24, 2019

Verification passed on

Brave 0.68.106 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

  • Verified Reddit pubs displayed in tips panel after sending tips
    image

  • Verified user can send a tip by clicking on inline tip link in Reddit posts

  • Verified Tip link is not shown when Reddit checkbox is unchecked in Tips panel in brave://rewards

  • Verified Tip link is not shown when brave://rewards is not enabled

Verification passed on

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#2665

  • Verified the inline tip link for Reddit posts
    image
  • Verified Reddit pubs displayed in tips panel after sending tips
    image
    • Verified user can send a tip by clicking on inline tip link in Reddit posts
    • Verified Tip link is not shown when Reddit checkbox is unchecked in Tips panel in brave://rewards
    • Verified Tip link is not shown when brave://rewards is not enabled

Verified passed with

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment