Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce build time flag for building Sparkle framework #4908

Closed
simonhong opened this issue Jun 14, 2019 · 2 comments · Fixed by brave/brave-core#2705
Closed

Introduce build time flag for building Sparkle framework #4908

simonhong opened this issue Jun 14, 2019 · 2 comments · Fixed by brave/brave-core#2705
Assignees
@bridiver
Labels
dev-concern OS/macOS QA Pass-macOS QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@simonhong
Copy link
Member

Most of devs doesn't need to build Sparkle framework for debug build.
@bridiver bridiver self-assigned this Jun 14, 2019
@bridiver bridiver added QA/Yes and removed QA/No labels Jun 14, 2019
@bridiver
Copy link
Contributor

QA should check to make sure updater works correctly

@bridiver bridiver mentioned this issue Jun 14, 2019
Merged
32 tasks
bridiver added a commit to brave/brave-core that referenced this issue Jun 14, 2019
@bridiver
only enable sparkle by default for official builds on mac
ed061c9 
fix brave/brave-browser#4908
@bridiver bridiver added this to the 0.68.x - Nightly milestone Jun 14, 2019
bridiver added a commit to brave/brave-core that referenced this issue Jun 18, 2019
@bridiver
only enable sparkle by default for official builds on mac
3d90738 
fix brave/brave-browser#4908
bridiver added a commit to brave/brave-core that referenced this issue Jun 19, 2019
@bridiver
only enable sparkle by default for official builds on mac (#2705)
b317f6e 
* only enable sparkle by default for official builds on mac
fix brave/brave-browser#4908
@simonhong simonhong mentioned this issue Jun 19, 2019
Merged
32 tasks
@kjozwiak kjozwiak mentioned this issue Aug 2, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 2, 2019 •
edited by kjozwiak
Loading

Verified passed with:

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
  • Updated from 0.67.112 to 0.68.116 without issue.
  • Updated from 0.68.114 to 0.68.116 without issue.

cc @kjozwiak to check on Mojave.

Verification PASSED on macOS 10.14.15 x64 using the following build:

Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
  • Upgraded from 0.67.112 CR: 76.0.3809.62 --> 0.68.119 CR: 76.0.3809.87
  • Upgraded from 0.68.114 CR: 76.0.3809.87 --> 0.68.119 CR: 76.0.3809.87

tmancey pushed a commit that referenced this issue Apr 9, 2020
@kjozwiak
Merge pull request #4908 from brave/pr4880_android_sitebanner_landsca…
062d4a8 
…pe_1.7.x

Add missing landscape layout resources for site banner activity. #8587 (uplift to 1.7.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
dev-concern OS/macOS QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

only enable sparkle by default for official builds on mac brave/brave-core
4 participants
@bridiver @kjozwiak @simonhong @LaurenWags