Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add missing landscape layout resources for site banner activity. #8587

Closed
gdregalo opened this issue Mar 7, 2020 · 2 comments · Fixed by brave/brave-core#4880
Closed

[Android] Add missing landscape layout resources for site banner activity. #8587

gdregalo opened this issue Mar 7, 2020 · 2 comments · Fixed by brave/brave-core#4880
Assignees
@gdregalo
Labels
android-core-release ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab
Milestone
Android Beta Rele...

Comments

@gdregalo
Copy link

gdregalo commented Mar 7, 2020

Description

Please add missing landscape layout resources for site banner activity.

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@gdregalo gdregalo added this to the 1.7.x - Nightly milestone Mar 7, 2020
@gdregalo gdregalo self-assigned this Mar 7, 2020
@gdregalo gdregalo mentioned this issue Mar 7, 2020
Merged
29 tasks
@gdregalo
Copy link
Author

gdregalo commented Mar 7, 2020

Screenshot_20200304-181255

@NejcZdovc NejcZdovc added feature/rewards OS/Android Fixes related to Android browser functionality labels Mar 11, 2020
@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 9.0 running 1.5.111 x64 stable build

  • Verified on landscape more the site banner is shown correctly
    image

Verification passed on OnePlus 6T with Android 10 running 1.5.111 x64 stable build

  • Verified on landscape more the site banner is shown correctly
    image

tmancey pushed a commit that referenced this issue Apr 9, 2020
@kjozwiak
Merge pull request #4908 from brave/pr4880_android_sitebanner_landsca…
062d4a8 
…pe_1.7.x

Add missing landscape layout resources for site banner activity. #8587 (uplift to 1.7.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdregalo gdregalo

Labels
android-core-release ARM Android ARM related issues bug feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab
Projects
None yet
Milestone
Android Beta Release 7
Development

Successfully merging a pull request may close this issue.

Add missing landscape layout resources for site banner activity. #8587 brave/brave-core
4 participants
@kjozwiak @NejcZdovc @srirambv @gdregalo