Browser crash when attempting to tweet after tipping #5516

btlechowski · 2019-08-02T13:33:38Z

After tipping, clicking on Tweet may crash the browser

Steps to Reproduce

Clean install on staging
Enable Rewards
Claim grant or fund wallet another way
Open publisher page (https://www.reddit.com/user/jsadler-brave)
Use inline tipping
Click tip amount
Quickly click another tip amount (repeat few times)
Immediately click SEND MY TIP
Immediately click Tweet

Note: This is an Intermittent issue, if browser does not crash, start from step 5.

Actual result:

Browser Crash. Needs to run the browser again.

Windows 7 Uploaded Crash Report ID 7c1b0025c7afe8b9 (Local Context: fe8dec3f-846c-494d-8c7f-6305e621f7a0)
Ubuntu 18.04 LTS Crash Report ID d165028fa3f61bfa

Expected result:

No crash

Reproduces how often:

Intermittent issue, around 20% repro rate

Brave version (brave://version info)

Brave	0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Ubuntu 18.04 LTS

Brave	0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Windows 7 Service Pack 1 (Build 7601.24494)

Reproduced on staging and production. Also reproduced by tipping youtube publisher.

cc @NejcZdovc @brave/legacy_qa

The text was updated successfully, but these errors were encountered:

btlechowski · 2019-08-08T23:07:51Z

Still reproducible

Brave	0.68.120 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Ubuntu 18.04 LTS

Uploaded Crash Report ID fa3223c63ab8d96c (Local Context: Brave)
Crash report uploaded on Friday, August 9, 2019 at 1:05:16 AM

masparrow · 2019-09-25T13:40:36Z

@NejcZdovc is it possible to get access to the crash reports cited above?

masparrow · 2019-09-25T13:44:13Z

@btlechowski hi - a quick question - when it works (doesn't crash) what does the 'Tweet' button do for you? For me, nothing happens after clicking other than it dismisses the banner.

Also, did you use a VPN to get the grant claim? If so which one please, as there may be a subtle timing issue involved.

btlechowski · 2019-09-30T11:27:25Z

@masparrow re grant, your don't really need the grant, you just need funds to tip

I reproduced the issue with Tweet button. This is not as it used to be before. Maybe it is related to the crash.
You should see something like that:

Does not reproduce on Twitter(inline tipping), youtube and regular page.

edit: I logged #6223. You are very likely blocked on this issue.

NejcZdovc · 2019-10-01T16:23:22Z

@btlechowski can you please send crash id or terminal logs

btlechowski · 2019-10-01T16:48:30Z

The crash ids are in the description.

I will repaste them for convenience:
Windows 7 Uploaded Crash Report ID 7c1b0025c7afe8b9 (Local Context: fe8dec3f-846c-494d-8c7f-6305e621f7a0)
Ubuntu 18.04 LTS Crash Report ID d165028fa3f61bfa
Uploaded Crash Report ID fa3223c63ab8d96c (Local Context: Brave)

NejcZdovc · 2019-10-01T16:53:00Z

@btlechowski thank you, I missed it.

masparrow · 2019-10-03T14:51:24Z

@btlechowski @LaurenWags with the fix from PR 3592 (which resolves #6223) I have been unable to reproduce the crash from this issue. I've burned through 60 BAT (and I'm a cheap tipper ;) )and every time the Tweet page loads as expected. I'd recommend retesting this issue once #6223 is resolved (slated for 0.72 nightly ATM).

LaurenWags · 2019-10-03T15:44:09Z

@masparrow if you would like, let us know once the fix for #6223 has been merged to Nightly (looks like it's still open atm) and we can check this on Nightly for you.

masparrow · 2019-10-03T19:02:49Z

@LaurenWags #6223 PR merged :) TIA!

LaurenWags · 2019-10-07T14:42:30Z

@btlechowski I have not been able to reproduce with the following version. Can you please retest as well?

Brave	0.72.72 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

btlechowski · 2019-10-08T01:47:12Z

I am still able to reproduce the crash. I was testing on staging with grant.

Brave	0.72.77 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

Uploaded Crash Report ID 0e2953da93e8455a (Local Context: Brave)

I will try to get a recording tomorrow. Maybe it will help.

masparrow · 2019-10-08T09:43:08Z

@btlechowski A recording would be great - just in case some subtle order of events or timing is key to reproducing.

btlechowski · 2019-10-08T11:34:07Z

I managed to record it.

I used staging env with a grant. I was connected to Belgium through VPN.

I also noticed that if crash does not reproduce, there is no need to start from step 1. It is OK to start from step 5.

Uploaded crash id for this crash: 0e594ec66abf309d

btlechowski · 2020-10-21T11:14:19Z

@kjozwiak The crash report was not generated. Probably due to #4296.

LaurenWags · 2020-10-21T12:12:58Z

@kjozwiak could not reproduce issue, updated #5516 (comment) with my notes. We should probably get a follow up issue logged for Win/Linux if this is still occurring there 👍

btlechowski · 2020-10-21T15:29:19Z

After internal discussion it was decided to reopen this issue and mark it as OS/Linux and OS/Windows

btlechowski · 2020-12-17T13:11:33Z

Still crashing

Brave	1.18.74 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Ubuntu 18.04 LTS

LaurenWags · 2020-12-17T14:25:03Z

I reproduced on Linux as well today

Brave	1.18.74 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Linux

Moving to Rewards Global board for triage cc @marshall

zenparsing · 2021-04-06T13:24:14Z

Possibly related: #15142

GeetaSarvadnya · 2021-04-16T09:43:10Z

Verification passed on


Brave | 1.24.65 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified the STR from the description and ensured there is no crash when tweet after tipping

Verification passed on

Brave	1.24.70 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	Ubuntu 18.04 LTS

Verified the STR from the description. No crash.
The twitter login was not shown. Logged #15565

btlechowski added crash feature/rewards intermittent-issue QA/Yes QA/Test-Plan-Specified labels Aug 2, 2019

rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 16, 2019

NejcZdovc assigned masparrow Sep 10, 2019

btlechowski mentioned this issue Sep 30, 2019

Cannot tweet after inline tipping on reddit #6223

Closed

masparrow mentioned this issue Oct 3, 2019

Collects media type when saving Reddit publisher data brave/brave-core#3592

Merged

32 tasks

NejcZdovc added this to the 0.72.x - Nightly milestone Oct 3, 2019

NejcZdovc removed this from the 0.72.x - Nightly milestone Oct 3, 2019

kjozwiak removed the QA Pass-macOS label Oct 20, 2020

LaurenWags added the QA Pass-macOS label Oct 21, 2020

btlechowski reopened this Oct 21, 2020

btlechowski added OS/Linux OS/Windows and removed QA Pass-macOS labels Oct 21, 2020

kjozwiak removed this from the 1.17.x - Beta milestone Oct 21, 2020

NejcZdovc unassigned emerick Oct 28, 2020

zenparsing self-assigned this Apr 6, 2021

zenparsing mentioned this issue Apr 6, 2021

Fix unsafe use of base::Unretained in tip dialog message handler brave/brave-core#8444

Merged

24 tasks

zenparsing closed this as completed in brave/brave-core#8444 Apr 6, 2021

zenparsing added this to the 1.24.x - Nightly milestone Apr 6, 2021

GeetaSarvadnya added the QA Pass-Win64 label Apr 16, 2021

btlechowski mentioned this issue Apr 29, 2021

Unable to tweet after tip on Linux #15565

Closed

btlechowski added the QA Pass-Linux label Apr 29, 2021

LaurenWags mentioned this issue May 4, 2021

[Desktop] Release Notes for 1.24.x Release #1 #15610

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Browser crash when attempting to tweet after tipping #5516

Browser crash when attempting to tweet after tipping #5516

btlechowski commented Aug 2, 2019 •

edited

Loading

btlechowski commented Aug 8, 2019

masparrow commented Sep 25, 2019

masparrow commented Sep 25, 2019 •

edited

Loading

btlechowski commented Sep 30, 2019 •

edited

Loading

NejcZdovc commented Oct 1, 2019

btlechowski commented Oct 1, 2019

NejcZdovc commented Oct 1, 2019

masparrow commented Oct 3, 2019

LaurenWags commented Oct 3, 2019

masparrow commented Oct 3, 2019

LaurenWags commented Oct 7, 2019

btlechowski commented Oct 8, 2019 •

edited

Loading

masparrow commented Oct 8, 2019

btlechowski commented Oct 8, 2019 •

edited

Loading

btlechowski commented Oct 21, 2020

LaurenWags commented Oct 21, 2020

btlechowski commented Oct 21, 2020

btlechowski commented Dec 17, 2020

LaurenWags commented Dec 17, 2020

zenparsing commented Apr 6, 2021

GeetaSarvadnya commented Apr 16, 2021 •

edited by btlechowski

Loading

Browser crash when attempting to tweet after tipping #5516

Browser crash when attempting to tweet after tipping #5516

Comments

btlechowski commented Aug 2, 2019 • edited Loading

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

btlechowski commented Aug 8, 2019

masparrow commented Sep 25, 2019

masparrow commented Sep 25, 2019 • edited Loading

btlechowski commented Sep 30, 2019 • edited Loading

NejcZdovc commented Oct 1, 2019

btlechowski commented Oct 1, 2019

NejcZdovc commented Oct 1, 2019

masparrow commented Oct 3, 2019

LaurenWags commented Oct 3, 2019

masparrow commented Oct 3, 2019

LaurenWags commented Oct 7, 2019

btlechowski commented Oct 8, 2019 • edited Loading

masparrow commented Oct 8, 2019

btlechowski commented Oct 8, 2019 • edited Loading

btlechowski commented Oct 21, 2020

LaurenWags commented Oct 21, 2020

btlechowski commented Oct 21, 2020

btlechowski commented Dec 17, 2020

LaurenWags commented Dec 17, 2020

zenparsing commented Apr 6, 2021

GeetaSarvadnya commented Apr 16, 2021 • edited by btlechowski Loading

btlechowski commented Aug 2, 2019 •

edited

Loading

masparrow commented Sep 25, 2019 •

edited

Loading

btlechowski commented Sep 30, 2019 •

edited

Loading

btlechowski commented Oct 8, 2019 •

edited

Loading

btlechowski commented Oct 8, 2019 •

edited

Loading

GeetaSarvadnya commented Apr 16, 2021 •

edited by btlechowski

Loading