Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collects media type when saving Reddit publisher data #3592

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Conversation

masparrow
Copy link
Contributor

@masparrow masparrow commented Oct 3, 2019

Resolves brave/brave-browser#6223
Resolves brave/brave-browser#6252

Submitter Checklist:

Test Plan:

As per #6223
As per #6252

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@masparrow masparrow added this to the 0.72.x - Nightly milestone Oct 3, 2019
@masparrow masparrow requested a review from a team October 3, 2019 10:23
@masparrow masparrow self-assigned this Oct 3, 2019
@masparrow masparrow added CI/skip-android Do not run CI builds for Android and removed CI/skip-android Do not run CI builds for Android labels Oct 3, 2019
@masparrow masparrow merged commit 6467212 into master Oct 3, 2019
@masparrow masparrow deleted the issues/6223 branch October 3, 2019 19:02
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants