Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crash when Tor/Guest/Private window is opened in some locales - follow up to 6421 #6476

Closed
LaurenWags opened this issue Oct 15, 2019 · 5 comments · Fixed by brave/brave-core#3738
Closed

Browser crash when Tor/Guest/Private window is opened in some locales - follow up to 6421 #6476

LaurenWags opened this issue Oct 15, 2019 · 5 comments · Fixed by brave/brave-core#3738
Assignees
@bsclifton
Labels
crash priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude
Milestone
0.70.x - Release

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 15, 2019 •
edited by bsclifton
Loading

Test plan

See below; things to check also called out in brave/brave-core#3738

Description

Follow up to #6421

When opening a Tor (or Guest or Private) window in some locales the browser crashes.

Germany - reproduced for Tor window. Example crash ID:

  • ID des hochgeladenen Absturzberichts: 28023ed33f3592c6 and ID des hochgeladenen Absturzberichts: fa92b9b0790c870d (a single tor window crash produced both of these)

Australia - reproduced for Private/Guest/Tor windows

  • Uploaded Crash Report ID 8696051c26a70879 (private window)
  • Uploaded Crash Report ID 6d17b8290e5946bd (guest window)
  • Uploaded Crash Report ID 7255cac588bfacd8 and Uploaded Crash Report ID e34ccf71f1365423 (a single tor window crash produced both of these)

New Zealand - reproduced for Private/Guest/Tor windows. Example crash ID:

  • Uploaded Crash Report ID 1fa0f102d8f4a37e (private window)
  • Uploaded Crash Report ID 2f5440506ed480f4 (guest window)
  • Uploaded Crash Report ID 0859b8564f4ac137 and Uploaded Crash Report ID 7cbea791ea099826 (a single tor window crash produced both of these)

Ireland - reproduced as well but forgot to save crashes. If you need them let me know and I'll generate more.

Could not reproduce with US/UK locales.

Steps to Reproduce

  1. Set system to an affected locale/language.
  2. Clean profile with 0.70.116.
  3. Open a Tor/Private/Guest window.

Actual result:

Crash

Expected result:

No crash

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.70.116 Chromium: 77.0.3865.90 (Offizieller Build) beta (64-Bit)
Überarbeitung 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
Betriebssystem macOS Version 10.13.6 (Build 17G5019)
Brave 0.72.100 Chromium: 78.0.3904.50 (Offizieller Build) nightly (64-Bit)
Überarbeitung 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
Betriebssystem macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no (using 0.69.135)
  • Can you reproduce this issue with the beta channel? yes using 0.70.116
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes using 0.72.100

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @bsclifton @rebron @brave/legacy_qa
@LaurenWags LaurenWags added this to the 0.70.x - Beta milestone Oct 15, 2019
@LaurenWags LaurenWags mentioned this issue Oct 15, 2019
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 15, 2019 •
edited
Loading

I am seeing the crash for Guest/PT/TOR for US locale also. Please find the attached recorded files - Tested in windows 10 x64 - 0.70.116

TOR window - https://drive.google.com/open?id=1t8RslWkFhQ1Nu_TCpVSsw3UYvmaRh0Zy
Private window - https://drive.google.com/open?id=1CdBx7AfZIu-MDUN5IsjuAg3vMKS6Ic2T
Guest window - https://drive.google.com/open?id=1a3wopbb006-0h7o68L5OU1rtS5KtcUd2

@bsclifton bsclifton self-assigned this Oct 17, 2019
bsclifton added a commit to brave/brave-core that referenced this issue Oct 17, 2019
@bsclifton
Fix default search logic for Tor window and guest window
c91a50e 
Fixes brave/brave-browser#6476

Specifically, fixes the engine when a previously set engine is no longer available.

For example, in DE the engine used to be DDG (501), but was changed in
the prepopulated list to DDG_DE(516). The value in the preferences will
not be able to be used to get a valid engine (and cause a crash). This
change checks if the currently selected engine is available and if not
resets the value to the currently preset default.
@bsclifton bsclifton mentioned this issue Oct 17, 2019
Merged
62 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Oct 20, 2019
@bsclifton
Fix default search logic for Tor window and guest window
90e4027 
Fixes brave/brave-browser#6476

Specifically, fixes the engine when a previously set engine is no longer available.

For example, in DE the engine used to be DDG (501), but was changed in
the prepopulated list to DDG_DE(516). The value in the preferences will
not be able to be used to get a valid engine (and cause a crash). This
change checks if the currently selected engine is available and if not
resets the value to the currently preset default.
This was referenced Oct 21, 2019
Merged
Merged
Merged
@btlechowski
Copy link

btlechowski commented Oct 21, 2019 •
edited
Loading

Verification passed on

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3738
Verified no crashes for following locales: en_AU, en_NZ, en_IE, ga_IE, de_DE, en_US, en_GB, pl_PL

Still reproducible, Logged #6565

@btlechowski btlechowski mentioned this issue Oct 21, 2019
Closed
@LaurenWags
Copy link
Member Author

Per discussion with @kjozwiak - removing QA Pass-Linux and marking as QA/Blocked until #6565 is resolved.

cc @brave/legacy_qa @rebron

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 22, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
  • Verified the locales the US, UK, New Zealand, Ireland, Germany, and Austalia. - No crash in PT/TOR/Guest windows
  • Verified both clean and upgraded profile
  • Verified no crash when sites are opened in PT/TOR/Guest windows
  • Verified no crash in PT/TOR/Guest windows, kept each window open for 20 secs and observed there is no crash

Verification passed on

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
  • Verified the locales the US, UK, New Zealand, Ireland, Germany, and Austalia. - No crash in PT/TOR/Guest windows
  • Verified both clean and upgraded profile
  • Verified no crash when sites are opened in PT/TOR/Guest windows

Verified passed with

Brave 0.70.120 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified the STR from the description
  • Verified the locales: Germany, Australia, New Zealand, Ireland, US. - No crash in PT/TOR/Guest windows
  • Verified both clean and upgraded profile
  • Verified no crash when sites are opened in PT/TOR/Guest windows
  • Verified no crash in PT/TOR/Guest windows, kept each window open for 20 secs and observed there is no crash

@LaurenWags
Copy link
Member Author

Removed QA/Blocked label as issue from #6476 (comment) was included in 0.70.120 so this issue can be tested now.

@LaurenWags LaurenWags mentioned this issue Oct 22, 2019
Closed
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
crash priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Fix default search logic for Tor window and guest window brave/brave-core
4 participants
@bsclifton @LaurenWags @btlechowski @GeetaSarvadnya