Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crash when new private window is opened in German locale #6421

Closed
btlechowski opened this issue Oct 10, 2019 · 8 comments · Fixed by brave/brave-core#3672
Closed

Browser crash when new private window is opened in German locale #6421

btlechowski opened this issue Oct 10, 2019 · 8 comments · Fixed by brave/brave-core#3672
Assignees
@bsclifton
Labels
crash priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No QA/Test-Plan-Specified regression release/blocking release-notes/exclude
Milestone
0.70.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Oct 10, 2019 •
edited
Loading

Found while testing #6187

Steps to Reproduce

  1. Set system locale to German/Germany
  2. Clean profile
  3. Open New private window

Actual result:

Crash

Uploaded Crash Report ID ad9fefcf0c82c402 (Local Context: 81524cdd-7e63-4ba4-bc71-e3bb80e51514)
Uploaded Crash Report ID a28ccf2265fd35b3 (Local Context: e58dd7e4-0be4-4804-97ed-5422b23bd0ff)

Expected result:

No Crash

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1903 (Build 18362.175)
Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

cc @brave/legacy_qa @rebron @bsclifton
@btlechowski btlechowski added this to the 0.70.x - Beta milestone Oct 10, 2019
@bsclifton bsclifton self-assigned this Oct 10, 2019
@rebron rebron added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Oct 10, 2019
@bsclifton
Copy link
Member

Great catch - looking into this now... Should be able to provide a fix tonite

@bsclifton bsclifton mentioned this issue Oct 11, 2019
Merged
32 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Oct 11, 2019
@bsclifton
Have a list of fall-back engines to try for private window search
eab3d1c 
Fixes brave/brave-browser#6421

Problem was regular DDG not found in the entries returned (since locale specific was returned instead).
Besides adding other entries, this also puts a dcheck in place to ensure an engine gets set (otherwise, the error thrown is no immediately clear and a bit hard to trace).

(bug unintentionally introduced with #3591)
This was referenced Oct 11, 2019
Merged
Merged
@LaurenWags
Copy link
Member

LaurenWags commented Oct 14, 2019 •
edited
Loading

Applies to Tor and Guest windows as well, we need to check them as well when verifying this issue. Also need to check new and upgrade profiles as this issue affects both.

Brave 0.70.115 Chromium: 77.0.3865.90 (Offizieller Build) beta (64-Bit)
Überarbeitung 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
Betriebssystem macOS Version 10.13.6 (Build 17G5019)

Need to check Australia, NZ, Ireland as well.

@btlechowski btlechowski mentioned this issue Oct 14, 2019
Closed
@rebron rebron mentioned this issue Oct 14, 2019
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 15, 2019 •
edited
Loading

The issue is Reproducible in windows 10 x64 - 0.70.113 - Open PT/TOR/Guest windows crashes the browser. Issue is consistently Reproducible for locales AU/IE/DE/New Zealand.

In one more scenario browser crashes for the US/UK locale

  1. OS locale is set to US
  2. Clean profile 0.70.113
  3. As soon as browser opens up, click Guest/TOR/PT window
  4. Keep the window open/idle for few seconds
  5. Browser crashes after 10 ~ 20 secs (sometimes before 5 secs browser crashes)

@bsclifton
Copy link
Member

@GeetaSarvadnya new beta has been released which has the fix, if you wanted to give it a go 😄

@GeetaSarvadnya
Copy link

@bsclifton Sure! Thanks for the update

@GeetaSarvadnya
Copy link

@bsclifton Issue is still reproducible in 0.70.116 for US locale, Checking other locales.

@LaurenWags LaurenWags mentioned this issue Oct 15, 2019
Closed
@LaurenWags
Copy link
Member

I couldn't reproduce for US/UK locales, but I did reproduce crashes with:
Germany (Tor window only)
Australia (Private/Guest/Tor windows)
New Zealand (Private/Guest/Tor windows)
Ireland (Tor window only)

Logged follow up issue: #6476 with crash report IDs in that issue.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 15, 2019 •
edited
Loading

Since issue is still occurring, marking as QA/No. Will be retested with new issue 6476.

@LaurenWags LaurenWags removed the QA/Yes label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
crash priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No QA/Test-Plan-Specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Have a list of fall-back engines to try for private window search brave/brave-core
5 participants
@bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya