Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make widget card stack padding and title size consistent #9249

Closed
rebron opened this issue Apr 15, 2020 · 1 comment · Fixed by brave/brave-core#5289
Closed

make widget card stack padding and title size consistent #9249

rebron opened this issue Apr 15, 2020 · 1 comment · Fixed by brave/brave-core#5289

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 15, 2020

Description

Widget card stack padding and title sizes need to be made consistent for all widgets in the stack

Design:

widget_card_stack_padding_and_title_sizes_need_to_be_made_consistent_for_all_widgets_in_the_stack

Brave version (brave://version info)

Brave 1.9.21 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS macOS Version 10.15.5 (Build 19F53f)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1909 (Build 18363.778)
  • Verified widget title uses 18px Poppins font
    image
  • Verified cards use rounded corners
    image
  • Logged issue for gap between card stack Gap behind card stack  #9385

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux
  • Verified widget title uses 18px Poppins font
  • Verified cards use rounded corners

Verification passed on

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified widget title uses 18px Poppins font
  • Verified cards use rounded corners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants